From: Christoph Hellwig <hch@infradead.org>
To: Naveen Burmi <naveenb@cisco.com>
Cc: linux-scsi@vger.kernel.org
Subject: Re: Request for review of Linux iSCSI driver version 4.0.0.3
Date: Sun, 28 Dec 2003 20:25:19 +0000 [thread overview]
Message-ID: <20031228202519.A22856@infradead.org> (raw)
In-Reply-To: <03121719101402.28899@naveenb-lnx.cisco.com>; from naveenb@cisco.com on Wed, Dec 17, 2003 at 07:10:14PM +0530
On Wed, Dec 17, 2003 at 07:10:14PM +0530, Naveen Burmi wrote:
>
> Folks,
>
> Thanks to all of you for the review of linux-iscsi driver 4.0.0.2. As on
> today all the review comments have been incorporated into 4.0.0.3 release.
I'm not sure whether this is true, there's still a lot of items missing.
Additional notes:
- lun_reset_occured references shost->__device, _please_ read the comment
above that struct member in scsi_host.h and act accordingly, okay?
- as Mike Christie you're doing multipathing in your driver. We don't
want vendor-specific multipathing code in scsi-drivers but instead
encurage using md or dm multipathing.
Note that all this wasn't really an indepth-review but rather looking over
the code a tiny bit. If you have fixed the list I have you on the first
review we can look at doing a more in-depth review.
next prev parent reply other threads:[~2003-12-28 20:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-12-17 13:40 Request for review of Linux iSCSI driver version 4.0.0.3 Naveen Burmi
2003-12-28 20:25 ` Christoph Hellwig [this message]
2003-12-29 15:11 ` Naveen Burmi
2003-12-29 21:23 ` Mike Christie
2003-12-31 11:07 ` Naveen Burmi
2003-12-31 21:22 ` Andre Hedrick
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20031228202519.A22856@infradead.org \
--to=hch@infradead.org \
--cc=linux-scsi@vger.kernel.org \
--cc=naveenb@cisco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox