From: Grant Grundler <grundler@parisc-linux.org>
To: Matthew Wilcox <willy@debian.org>
Cc: Andrew Morton <akpm@osdl.org>,
linux-scsi@vger.kernel.org, linux-pci@atrey.karlin.mff.cuni.cz
Subject: Re: i450nx-scanning-fix.patch
Date: Tue, 30 Dec 2003 12:18:54 -0700 [thread overview]
Message-ID: <20031230191854.GB19852@colo.lackof.org> (raw)
In-Reply-To: <20031229122809.GF12479@parcelfarce.linux.theplanet.co.uk>
On Mon, Dec 29, 2003 at 12:28:09PM +0000, Matthew Wilcox wrote:
> Well, I made the same mistake in this patch as I made in a later patch, so
> I know it never worked for anyone. Namely, pci_bus->children is the list
> of child busses, not the list of devices on the bus. That's ->devices.
Yeah - it's not obvious unless one looks at the types carefully.
> I swear I'm going to write a for_each_pci_device_on_this_bus() macro so
> I don't make the same mistake a third time.
Can we rename "children" to "secondary_busses" or something like that?
grant
prev parent reply other threads:[~2003-12-30 19:18 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-12-29 11:02 i450nx-scanning-fix.patch Andrew Morton
2003-12-29 11:24 ` i450nx-scanning-fix.patch Arjan van de Ven
2003-12-29 11:27 ` i450nx-scanning-fix.patch Andrew Morton
2003-12-29 11:38 ` i450nx-scanning-fix.patch Arjan van de Ven
2003-12-29 12:28 ` i450nx-scanning-fix.patch Matthew Wilcox
2003-12-30 19:18 ` Grant Grundler [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20031230191854.GB19852@colo.lackof.org \
--to=grundler@parisc-linux.org \
--cc=akpm@osdl.org \
--cc=linux-pci@atrey.karlin.mff.cuni.cz \
--cc=linux-scsi@vger.kernel.org \
--cc=willy@debian.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox