On Wed, Dec 31, 2003 at 11:36:26AM -0700, Justin T. Gibbs wrote: > > consistent memory ALWAYS comes from lower 4Gb regardless of the > > pci_set_dma_mask() setting; > > This isn't true on some architectures in the 2.4 kernel. Look at, for > example, arch/ia64/hp/common/sba_iommu.c in the RedHat 2.4.18-e.31 kernel. > This is why this particular hack was added. Thank you for reporting this very serious bug in our kernel; we will fix it as soon as possible. > I'm more than happy to change the #ifdefs on the hack to exclude 2.6 > so long as all platforms the driver operates under behave as expected. > If 2.4 is any guide, however, there may still be some bogus code lurking > around that uses the "normal" dma mask incorrectly. Those platforms break the API and should be fixed as opposed to hacks added to every single driver in drivers/* Greetings, Arjan van de Ven