From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [patch] 2.6.1-rc2-mm1: qla1280.c doesn't compile Date: Fri, 9 Jan 2004 13:49:42 +0000 Sender: linux-kernel-owner@vger.kernel.org Message-ID: <20040109134942.A24302@infradead.org> References: <20040107232831.13261f76.akpm@osdl.org> <20040109015229.GK13867@fs.tum.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20040109015229.GK13867@fs.tum.de>; from bunk@fs.tum.de on Fri, Jan 09, 2004 at 02:52:30AM +0100 To: Adrian Bunk Cc: Andrew Morton , Jes Sorensen , Christoph Hellwig , linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org List-Id: linux-scsi@vger.kernel.org On Fri, Jan 09, 2004 at 02:52:30AM +0100, Adrian Bunk wrote: > I got the following compile error when trying to compile this driver > statically into a kernel with hotplug enabled: Jes, that's your ifdef-magic around around qla1280_remove_one.. Do you remember why you added it? The only case we don't need it is when the driver is builtin and CONFIG_HOTPLUG is not set - and in that case __devexit should get rid of it for us. > Since I don't see a good reason why qla1280_remove_one is #ifdef'ed out > in the non-modular case the patch below fixes this problem by removing > two #ifdef's. The patch looks good to me. In fact that's how it was in the patch I sent to Jes..