Re: Transport Attributes -- attempt#3

[Martin Hicks <mort@bork.org>]

On Thu, Jan 15, 2004 at 01:52:16PM +0100, Martin Peschke3 wrote:
> Hi,
> 
> +     if (sdev->transport_classdev.class) {
> +           attrs = sdev->host->transportt->attrs;
> +           for (i = 0; attrs[i]; i++) {
> +                 error = class_device_create_file
> (&sdev->transport_classdev,
> +                                         attrs[i]);
> +                 if (error)
> +                       scsi_remove_device(sdev);
> +           }
> +     }
> 
> Isn't there a break needed in the error case to quit
> the loop after scsi_remove_device(sdev) in order to
> avoid trouble with sdev in subsequent iterations?
> I am not very familiar with the 2.6 SCSI code. But,
> is scsi_remove_device(sdev) an appropriate answer
> to the failed registration of sysfs attributes?

It looks that way.  There are a couple other places in the same function
that need similar fixes.

Thanks
mh

-- 
Martin Hicks || mort@bork.org || PGP/GnuPG: 0x4C7F2BEE