From: Christoph Hellwig <hch@infradead.org>
To: Jes Sorensen <jes@trained-monkey.org>
Cc: linux-scsi@vger.kernel.org, akpm@osdl.org,
James.Bottomley@steeleye.com, jeremy@sgi.com
Subject: Re: [patch] qla1280 update for 2.6.1-mm4
Date: Mon, 19 Jan 2004 12:14:06 +0000 [thread overview]
Message-ID: <20040119121406.A32409@infradead.org> (raw)
In-Reply-To: <16395.51364.833229.536552@gargle.gargle.HOWL>; from jes@trained-monkey.org on Mon, Jan 19, 2004 at 07:08:04AM -0500
On Mon, Jan 19, 2004 at 07:08:04AM -0500, Jes Sorensen wrote:
> +#ifdef QLA_64BIT_PTR
> static int qla1280_64bit_start_scsi(struct scsi_qla_host *, struct srb *);
> +#else
> static int qla1280_32bit_start_scsi(struct scsi_qla_host *, struct srb *);
> +#endif
Shouldn't you just call both of those qla1280_start_scsi if only one of
them is compiled at a time anyway?
> +#ifdef QLA_64BIT_PTR
> + /*
> + * Using 64 bit commands if the PCI bridge doesn't support it is a
> + * bit wasteful, however this should really only happen if one's
> + * PCI controller is completely broken, like the BCM1250. For
> + * sane hardware this is not an issue.
> + */
> + status = qla1280_64bit_start_scsi(ha, sp);
> +#else
> + status = qla1280_32bit_start_scsi(ha, sp);
> +#endif
That would also clean up this nicely..
next prev parent reply other threads:[~2004-01-19 12:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-01-19 12:08 [patch] qla1280 update for 2.6.1-mm4 Jes Sorensen
2004-01-19 12:14 ` Christoph Hellwig [this message]
2004-01-19 12:27 ` Jes Sorensen
2004-01-19 17:03 ` James Bottomley
2004-01-19 21:18 ` Jes Sorensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040119121406.A32409@infradead.org \
--to=hch@infradead.org \
--cc=James.Bottomley@steeleye.com \
--cc=akpm@osdl.org \
--cc=jeremy@sgi.com \
--cc=jes@trained-monkey.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox