Re: [PATCH] allow drivers to hook into watchdog timeout

[Mike Anderson <andmike@us.ibm.com>]

Christoph Hellwig [hch@lst.de] wrote:
> On Tue, Jan 20, 2004 at 07:53:20AM -0800, Mike Anderson wrote:
> > Christoph Hellwig [hch@lst.de] wrote:
> > > to get control first after a command timeout.  Justin, does this look
> > > okay for you?  BTW, your drivers are the last ones using scsi_add_timer
> > > from outside the midlayer, if we could get rid of that we'd be able to
> > > keep the interface private.
> > > 
> > 
> > If a LLDD uses this interface how does the scsi_cmnd get returned back
> > to the mid-layer?
> 
> My thoughts about this interface would be that the driver performs
> internals actions of whatever means and then calls scsi_eh_scmd_add
> anyway - that's why it moved out of scsi_priv.h
> 

Sorry I read the patch to fast and missed the move.

> > If one uses scsi_done without a timer set it will
> > believe that the error handler is running and not pass it on to
> > scsi_softirq.
> 
> We could change that by moving the guts of scsi_done to a new
> __scsi_done and then make scsi_done a tiny wrapper around it, e.g:
> 

I assume the wrapper would only help if we went the direction of having
the LLDD call __scsi_done directly under some recovery case?

-andmike
--
Michael Anderson
andmike@us.ibm.com