[2.6 patch] show "Fusion MPT device support" menu only if BLK_DEV_SD

[2.6 patch] show "Fusion MPT device support" menu only if BLK_DEV_SD

[Adrian Bunk]

With BLK_DEV_SD=n, I see a "Fusion MPT device support" menu I can't 
enter.

The simple patch below removes the "Fusion MPT device support" menu if 
BLK_DEV_SD=n.

Please apply
Adrian

--- linux-2.6.1-mm5/drivers/message/fusion/Kconfig.old	2004-01-21 00:19:12.000000000 +0100
+++ linux-2.6.1-mm5/drivers/message/fusion/Kconfig	2004-01-21 00:19:29.000000000 +0100
@@ -1,9 +1,9 @@
 
 menu "Fusion MPT device support"
+	depends on BLK_DEV_SD
 
 config FUSION
 	tristate "Fusion MPT (base + ScsiHost) drivers"
-	depends on BLK_DEV_SD
 	---help---
 	  LSI Logic Fusion(TM) Message Passing Technology (MPT) device support
 	  provides high performance SCSI host initiator, and LAN [1] interface

Re: [2.6 patch] show "Fusion MPT device support" menu only if BLK_DEV_SD

[Christoph Hellwig]

On Wed, Jan 21, 2004 at 12:25:07AM +0100, Adrian Bunk wrote:
> With BLK_DEV_SD=n, I see a "Fusion MPT device support" menu I can't 
> enter.
> 
> The simple patch below removes the "Fusion MPT device support" menu if 
> BLK_DEV_SD=n.

I'd rather see an explanation from LSI why a scsi LLDD depens on a uper
driver.  This can't be right.

Re: [2.6 patch] show "Fusion MPT device support" menu only if BLK_DEV_SD

[Andrew Morton]

Christoph Hellwig <hch@infradead.org> wrote:
>
> On Wed, Jan 21, 2004 at 12:25:07AM +0100, Adrian Bunk wrote:
> > With BLK_DEV_SD=n, I see a "Fusion MPT device support" menu I can't 
> > enter.
> > 
> > The simple patch below removes the "Fusion MPT device support" menu if 
> > BLK_DEV_SD=n.
> 
> I'd rather see an explanation from LSI why a scsi LLDD depens on a uper
> driver.  This can't be right.

There's a hint in the config help:

          [2] In order enable capability to boot the linux kernel
          natively from a Fusion MPT target device, you MUST
          answer Y here! (currently requires CONFIG_BLK_DEV_SD)

But a kernel built with BLK_DEV_SD=n, FUSION=y builds and links OK.

Re: [2.6 patch] show "Fusion MPT device support" menu only if BLK_DEV_SD

[Christoph Hellwig]

On Tue, Jan 20, 2004 at 04:03:46PM -0800, Andrew Morton wrote:
>           [2] In order enable capability to boot the linux kernel
>           natively from a Fusion MPT target device, you MUST
>           answer Y here! (currently requires CONFIG_BLK_DEV_SD)

Well, that's true for any LLDD.

Re: [2.6 patch] show "Fusion MPT device support" menu only if BLK_DEV_SD

[Matthew Wilcox]

On Tue, Jan 20, 2004 at 04:03:46PM -0800, Andrew Morton wrote:
> There's a hint in the config help:
> 
>           [2] In order enable capability to boot the linux kernel
>           natively from a Fusion MPT target device, you MUST
>           answer Y here! (currently requires CONFIG_BLK_DEV_SD)
> 
> But a kernel built with BLK_DEV_SD=n, FUSION=y builds and links OK.

This is one of the patches I have in my tree.  Andrew, shall I start
feeding all my Kconfig cleanups through you rather than through
kernel-janitors?

-- 
"Next the statesmen will invent cheap lies, putting the blame upon 
the nation that is attacked, and every man will be glad of those
conscience-soothing falsities, and will diligently study them, and refuse
to examine any refutations of them; and thus he will by and by convince 
himself that the war is just, and will thank God for the better sleep 
he enjoys after this process of grotesque self-deception." -- Mark Twain

Re: [2.6 patch] show "Fusion MPT device support" menu only if BLK_DEV_SD

[Andrew Morton]

Matthew Wilcox <willy@debian.org> wrote:
>
> Andrew, shall I start
>  feeding all my Kconfig cleanups through you rather than through
>  kernel-janitors?

Doesn't Randy have some system going there?

Re: [2.6 patch] show "Fusion MPT device support" menu only if BLK_DEV_SD

[Randy.Dunlap]

On Sun, 25 Jan 2004 15:11:07 -0800 Andrew Morton <akpm@osdl.org> wrote:

| Matthew Wilcox <willy@debian.org> wrote:
| >
| > Andrew, shall I start
| >  feeding all my Kconfig cleanups through you rather than through
| >  kernel-janitors?
| 
| Doesn't Randy have some system going there?

Yes, some system, but I think that Matthew should go ahead
and send this one to you.

--
~Randy