Re: [PATCH] change scsi_cmd_ioctl to take a gendisk instead of a queue

[Christoph Hellwig <hch@infradead.org>]

On Sun, Feb 01, 2004 at 12:48:03PM -0800, Patrick Mansfield wrote:
> Jens or others, any comments?
> 
> This patch against a recent bk 2.6 changes scsi_cmd_ioctl to take a
> gendisk as an argument instead of a request_queue_t. This allows scsi char
> devices to use the scsi_cmd_ioctl interface.

Heh, I had pretty much the same patch in 2.5.  I don't rember why
I dropped it but you're looks at least as nice.

> If the scsi upper level scsi_cmd_ioctl usage were consolidated in
> scsi_prep_fn, we could pass a request_queue_t instead of a gendisk to
> scsi_cmd_ioctl.

I don't parse that.  You mean taking REQ_PC handling from upper drivers
to the scsi core?

> +int bio_add_page(struct bio *bio, struct page *page, unsigned int len,
> +		 unsigned int offset)
> +{
> +	return __bio_add_page(bdev_get_queue(bio->bi_bdev), bio, page,
> +			      len, offset);
> +}

Maybe worth inlining in a header?