From: Christoph Hellwig <hch@infradead.org>
To: Patrick Mansfield <patmans@us.ibm.com>
Cc: Christoph Hellwig <hch@infradead.org>, Jens Axboe <axboe@suse.de>,
linux-scsi@vger.kernel.org
Subject: Re: [PATCH] change scsi_cmd_ioctl to take a gendisk instead of a queue
Date: Sun, 1 Feb 2004 22:13:55 +0000 [thread overview]
Message-ID: <20040201221355.A18561@infradead.org> (raw)
In-Reply-To: <20040201134916.A18509@beaverton.ibm.com>; from patmans@us.ibm.com on Sun, Feb 01, 2004 at 01:49:16PM -0800
On Sun, Feb 01, 2004 at 01:49:16PM -0800, Patrick Mansfield wrote:
> Yes. That would also clean up the upper level driver code (for example,
> sd.c's sd_init_command), but I have not tried this.
Heh, I just took a short look at sd_rw_intr vs rw_intr (sr) and moving
those into common code defintily looks like a good thing. There's a
bunch of small difference, but I think we'd better off having those
two unified instead of two sets of bugs. It's probably worth investigating.
> Then in the future we could use sg_io instead of the scsi_do_req,
> scsi_wait_req, etc., and get rid of REQ_CMD in favor of REQ_BLOCK_PC.
Hmmm.. Sound like an interesting path to investigate. But unlike the
REQ_PC unification it sounds more like a 2.7 thing.
next prev parent reply other threads:[~2004-02-01 22:14 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-02-01 20:48 [PATCH] change scsi_cmd_ioctl to take a gendisk instead of a queue Patrick Mansfield
2004-02-01 20:50 ` [PATCH] add scsi_cmd_ioctl (SG_IO) support for st Patrick Mansfield
2004-02-01 21:35 ` Christoph Hellwig
2004-02-01 21:51 ` Patrick Mansfield
2004-02-01 22:28 ` Willem Riede
2004-02-01 22:36 ` Christoph Hellwig
2004-02-01 21:33 ` [PATCH] change scsi_cmd_ioctl to take a gendisk instead of a queue Christoph Hellwig
2004-02-01 21:49 ` Patrick Mansfield
2004-02-01 22:13 ` Christoph Hellwig [this message]
2004-02-02 13:27 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040201221355.A18561@infradead.org \
--to=hch@infradead.org \
--cc=axboe@suse.de \
--cc=linux-scsi@vger.kernel.org \
--cc=patmans@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox