From: Willem Riede <wrlk@riede.org>
To: Christoph Hellwig <hch@infradead.org>
Cc: linux-scsi@vger.kernel.org
Subject: Re: [PATCH] add scsi_cmd_ioctl (SG_IO) support for st
Date: Sun, 1 Feb 2004 17:28:18 -0500 [thread overview]
Message-ID: <20040201222818.GI26962@serve.riede.org> (raw)
In-Reply-To: <20040201213552.B17988@infradead.org> (from hch@infradead.org on Sun, Feb 01, 2004 at 16:35:52 -0500)
On 2004.02.01 16:35, Christoph Hellwig wrote:
> > +static void st_intr(struct scsi_cmnd *SCpnt)
> > +{
>
> What about st_done instead? I know sd and sr use the intr names, but
> they're really misleading. Also convention for new code is to use
> cmd or scmd as variable names for scsi commands.
Is there any desire to change SCpnt to scmd in existing code (such as osst)?
Thanks, Willem Riede.
next prev parent reply other threads:[~2004-02-01 22:28 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-02-01 20:48 [PATCH] change scsi_cmd_ioctl to take a gendisk instead of a queue Patrick Mansfield
2004-02-01 20:50 ` [PATCH] add scsi_cmd_ioctl (SG_IO) support for st Patrick Mansfield
2004-02-01 21:35 ` Christoph Hellwig
2004-02-01 21:51 ` Patrick Mansfield
2004-02-01 22:28 ` Willem Riede [this message]
2004-02-01 22:36 ` Christoph Hellwig
2004-02-01 21:33 ` [PATCH] change scsi_cmd_ioctl to take a gendisk instead of a queue Christoph Hellwig
2004-02-01 21:49 ` Patrick Mansfield
2004-02-01 22:13 ` Christoph Hellwig
2004-02-02 13:27 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040201222818.GI26962@serve.riede.org \
--to=wrlk@riede.org \
--cc=hch@infradead.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox