From: Christoph Hellwig <hch@infradead.org>
To: Willem Riede <wrlk@riede.org>
Cc: linux-scsi@vger.kernel.org
Subject: Re: [PATCH] add scsi_cmd_ioctl (SG_IO) support for st
Date: Sun, 1 Feb 2004 22:36:49 +0000 [thread overview]
Message-ID: <20040201223649.A18653@infradead.org> (raw)
In-Reply-To: <20040201222818.GI26962@serve.riede.org>; from wrlk@riede.org on Sun, Feb 01, 2004 at 05:28:18PM -0500
On Sun, Feb 01, 2004 at 05:28:18PM -0500, Willem Riede wrote:
> > What about st_done instead? I know sd and sr use the intr names, but
> > they're really misleading. Also convention for new code is to use
> > cmd or scmd as variable names for scsi commands.
>
> Is there any desire to change SCpnt to scmd in existing code (such as osst)?
For the scsi midlayer (and new driver if possible) it would be nice to
have a single common notation. For existing drivers it's of course
left to the author.
That beeing said it would of course be nice to have driver/scsi/ as
homogeneous as possible.
next prev parent reply other threads:[~2004-02-01 22:36 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-02-01 20:48 [PATCH] change scsi_cmd_ioctl to take a gendisk instead of a queue Patrick Mansfield
2004-02-01 20:50 ` [PATCH] add scsi_cmd_ioctl (SG_IO) support for st Patrick Mansfield
2004-02-01 21:35 ` Christoph Hellwig
2004-02-01 21:51 ` Patrick Mansfield
2004-02-01 22:28 ` Willem Riede
2004-02-01 22:36 ` Christoph Hellwig [this message]
2004-02-01 21:33 ` [PATCH] change scsi_cmd_ioctl to take a gendisk instead of a queue Christoph Hellwig
2004-02-01 21:49 ` Patrick Mansfield
2004-02-01 22:13 ` Christoph Hellwig
2004-02-02 13:27 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040201223649.A18653@infradead.org \
--to=hch@infradead.org \
--cc=linux-scsi@vger.kernel.org \
--cc=wrlk@riede.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox