public inbox for linux-scsi@vger.kernel.org
 help / color / mirror / Atom feed
From: Kurt Garloff <garloff@suse.de>
To: Linux SCSI list <linux-scsi@vger.kernel.org>
Cc: James Bottomley <James.Bottomley@steeleye.com>
Subject: [PATCH] sysfs host name support
Date: Mon, 9 Feb 2004 16:50:46 +0100	[thread overview]
Message-ID: <20040209155046.GP3944@tpkurt.garloff.de> (raw)


[-- Attachment #1.1: Type: text/plain, Size: 759 bytes --]

Hi,

in scsidev, the host adapter name is one of the possible attributes to
match when providing persistent device names.
And the module name is useful to deduce the list of modules that is 
needed when booting.
The proc_name was used previously for /proc/scsi/PROC_NAME/X/ and is
still part of the host template. We might consider ripping is out
or think about syncing it with the module name.

Unfortunately neither is visible in sysfs currently.

Please apply the attached patch.
It exports the 3 names to sysfs under /sys/classes/scsi_hosts/hostX/
name, proc_name, module_name.

Regards,
-- 
Kurt Garloff  <garloff@suse.de>                            Cologne, DE 
SUSE LINUX AG, Nuernberg, DE                          SUSE Labs (Head)

[-- Attachment #1.2: scsi_sysfs-addnames.diff --]
[-- Type: text/plain, Size: 2035 bytes --]

--- drivers/scsi/scsi_sysfs.c.orig	2004-01-09 07:59:10.000000000 +0100
+++ drivers/scsi/scsi_sysfs.c	2004-02-09 16:29:30.226170112 +0100
@@ -58,21 +58,24 @@
  * shost_show_function: macro to create an attr function that can be used to
  * show a non-bit field.
  */
-#define shost_show_function(field, format_string)			\
+#define shost_show_function(name, field, format_string)			\
 static ssize_t								\
-show_##field (struct class_device *class_dev, char *buf)		\
+show_##name (struct class_device *class_dev, char *buf)			\
 {									\
 	struct Scsi_Host *shost = class_to_shost(class_dev);		\
-	return snprintf (buf, 20, format_string, shost->field);	\
+	return snprintf (buf, 20, format_string, shost->field);		\
 }
 
 /*
  * shost_rd_attr: macro to create a function and attribute variable for a
  * read only field.
  */
-#define shost_rd_attr(field, format_string)				\
-	shost_show_function(field, format_string)			\
-static CLASS_DEVICE_ATTR(field, S_IRUGO, show_##field, NULL)
+#define shost_rd_attr2(name, field, format_string)			\
+	shost_show_function(name, field, format_string)			\
+static CLASS_DEVICE_ATTR(name, S_IRUGO, show_##name, NULL)
+
+#define shost_rd_attr(field, format_string) \
+shost_rd_attr2(field, field, format_string)
 
 /*
  * Create the actual show/store functions and data structures.
@@ -96,6 +99,9 @@
 shost_rd_attr(cmd_per_lun, "%hd\n");
 shost_rd_attr(sg_tablesize, "%hu\n");
 shost_rd_attr(unchecked_isa_dma, "%d\n");
+shost_rd_attr2(name, hostt->name, "%s\n");
+shost_rd_attr2(proc_name, hostt->proc_name, "%s\n");
+shost_rd_attr2(module_name, hostt->module->name, "%s\n");
 
 static struct class_device_attribute *scsi_sysfs_shost_attrs[] = {
 	&class_device_attr_unique_id,
@@ -103,6 +109,9 @@
 	&class_device_attr_cmd_per_lun,
 	&class_device_attr_sg_tablesize,
 	&class_device_attr_unchecked_isa_dma,
+	&class_device_attr_name,
+	&class_device_attr_proc_name,
+	&class_device_attr_module_name,
 	&class_device_attr_scan,
 	NULL
 };

[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]

             reply	other threads:[~2004-02-09 15:50 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-02-09 15:50 Kurt Garloff [this message]
2004-02-09 16:05 ` [PATCH] sysfs host name support Christoph Hellwig
2004-02-09 16:09   ` James Bottomley
2004-02-09 16:20     ` Christoph Hellwig
2004-02-10  0:33       ` Kurt Garloff
2004-02-29 23:37         ` Kurt Garloff
2004-02-09 16:16   ` Kurt Garloff

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040209155046.GP3944@tpkurt.garloff.de \
    --to=garloff@suse.de \
    --cc=James.Bottomley@steeleye.com \
    --cc=linux-scsi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox