From: Christoph Hellwig <hch@infradead.org>
To: Kurt Garloff <garloff@suse.de>,
Linux SCSI list <linux-scsi@vger.kernel.org>,
James Bottomley <James.Bottomley@steeleye.com>
Subject: Re: [PATCH] sysfs host name support
Date: Mon, 9 Feb 2004 16:05:27 +0000 [thread overview]
Message-ID: <20040209160526.A23604@infradead.org> (raw)
In-Reply-To: <20040209155046.GP3944@tpkurt.garloff.de>; from garloff@suse.de on Mon, Feb 09, 2004 at 04:50:46PM +0100
On Mon, Feb 09, 2004 at 04:50:46PM +0100, Kurt Garloff wrote:
> Please apply the attached patch.
> It exports the 3 names to sysfs under /sys/classes/scsi_hosts/hostX/
> name, proc_name, module_name.
name is optional (you can use ->info instead), so please don't export it.
As for proc_name vs module_name - I think we should just export one of them,
I'm pretty open which one. proc_name probably makes more sense.
> +shost_rd_attr2(module_name, hostt->module->name, "%s\n");
How does this work for builtin modules? Last time I checked hostt->module
was NULL for those.
next prev parent reply other threads:[~2004-02-09 16:05 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-02-09 15:50 [PATCH] sysfs host name support Kurt Garloff
2004-02-09 16:05 ` Christoph Hellwig [this message]
2004-02-09 16:09 ` James Bottomley
2004-02-09 16:20 ` Christoph Hellwig
2004-02-10 0:33 ` Kurt Garloff
2004-02-29 23:37 ` Kurt Garloff
2004-02-09 16:16 ` Kurt Garloff
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040209160526.A23604@infradead.org \
--to=hch@infradead.org \
--cc=James.Bottomley@steeleye.com \
--cc=garloff@suse.de \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox