From: Andrew Morton <akpm@osdl.org>
To: "Steven J. Hill" <sjhill@realitydiluted.com>
Cc: linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org
Subject: Re: [PATCH] 2.6.2, Partition support for SCSI CDROM...
Date: Sun, 22 Feb 2004 19:00:47 -0800 [thread overview]
Message-ID: <20040222190047.01f6f024.akpm@osdl.org> (raw)
In-Reply-To: <40396134.6030906@realitydiluted.com>
"Steven J. Hill" <sjhill@realitydiluted.com> wrote:
>
> Greetings.
>
> This patch enables support for CDROMs that have partitions on
> them, like say SGI and SUN media. It was sent to me by Christoph
> Hellwig and then I cleaned it up a bit. I am posting it more
> for flamebait^Wcomments to see if people are comfortable with it.
> +config BLK_DEV_SR_PARTITIONS
> +config BLK_DEV_SR_PARTITIONS_PER_DEVICE
Do we actually need these config options? Why not hardwire it to some
reasonable upper bound and be done with it?
>
> +#ifdef MODULE
> + /* Check number of partitions specified. */
> + if (partitions < 0)
> + partitions = 0;
> +#endif
> +
Why is this ifdef needed?
next prev parent reply other threads:[~2004-02-23 3:00 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-02-23 2:11 [PATCH] 2.6.2, Partition support for SCSI CDROM Steven J. Hill
2004-02-23 3:00 ` Andrew Morton [this message]
2004-02-23 3:07 ` Steven J. Hill
2004-02-23 3:13 ` Andrew Morton
2004-02-24 6:11 ` Jeremy Higdon
2004-02-24 16:51 ` Steven J. Hill
2004-02-24 17:06 ` Christoph Hellwig
2004-02-26 22:51 ` Rusty Russell
2004-02-24 17:09 ` Matthew Wilcox
2004-02-25 1:58 ` Miles Bader
2004-02-25 10:19 ` Andries Brouwer
2004-02-27 3:22 ` Bill Davidsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040222190047.01f6f024.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=sjhill@realitydiluted.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox