From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jens Axboe Subject: Re: PROBLEM: 2.6.3 hangs when writing to scsi-dvd Date: Mon, 23 Feb 2004 20:05:36 +0100 Sender: linux-scsi-owner@vger.kernel.org Message-ID: <20040223190536.GN32010@suse.de> References: <403512B8.2060403@ics.uci.edu> <20040223142531.GF32010@suse.de> <200402231921.33895.pieczy@web.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from ns.virtualhost.dk ([195.184.98.160]:29866 "EHLO virtualhost.dk") by vger.kernel.org with ESMTP id S262002AbUBWTFj (ORCPT ); Mon, 23 Feb 2004 14:05:39 -0500 Content-Disposition: inline In-Reply-To: <200402231921.33895.pieczy@web.de> List-Id: linux-scsi@vger.kernel.org To: Frank Pieczynski Cc: Kai Makisara , Joachim Feise , linux-scsi@vger.kernel.org, Michael Guntsche , Andrew Morton , "Justin T. Gibbs" On Mon, Feb 23 2004, Frank Pieczynski wrote: > On Monday 23 February 2004 15:25, Jens Axboe wrote: > > > > > I hope someone sees no where the real problem is. > > > > > > > > SCSI io completion path (sr/sd/st rw_intr() -> scsi_io_completion() -> > > > > scsi_end_request()) doesn't properly handle non-sector aligned data > > > > transfers. This patch should fix it up. Warning: untested. > > > > > > Now it is slightly tested: it works with my SCSI tape test program. Since > > > the program only does an inquiry, I tried it with the SCSI system disk > > > without problems. Unfortunately, I don't have access to a SCSI CDROM now. > > > > Great, that's promising (code like this tends to either break at first > > access, or work :-). Thanks for testing. > > Hello all, > yes, this fix works! I can open k3b now without problems. > And yes, my other SCSI devices are still working, also my SATA disks using > libata. > Thank you ver much, Andrew, care to shake it down in -mm for a release? IMO it's clearly the way to go (changing io completion to be byte based instead of sectors), and the patch looks ok to me (well obviously :-) -- Jens Axboe