From: Christoph Hellwig <hch@infradead.org>
To: "Steven J. Hill" <sjhill@realitydiluted.com>
Cc: Jeremy Higdon <jeremy@sgi.com>, Andrew Morton <akpm@osdl.org>,
linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org
Subject: Re: [PATCH] 2.6.2, Partition support for SCSI CDROM...
Date: Tue, 24 Feb 2004 17:06:26 +0000 [thread overview]
Message-ID: <20040224170626.A25066@infradead.org> (raw)
In-Reply-To: <403B8108.6080606@realitydiluted.com>; from sjhill@realitydiluted.com on Tue, Feb 24, 2004 at 11:51:20AM -0500
On Tue, Feb 24, 2004 at 11:51:20AM -0500, Steven J. Hill wrote:
> Here is the second try at the patch.
>
> -Steve
+static int partitions = 16;
This is changes what sr1 is mapped to without specicying any option.
The default _must_ be 0 partitions or existing setups will break.
+MODULE_PARM(partitions, "i");
please make this module_param so it works at boot-time aswell.
+MODULE_PARM_DESC(partitions, "number of SCSI CDROM partitions to support");
+ /* Check number of partitions specified. */
+ if (partitions < 0)
+ partitions = 0;
now if you made the variable 'unsigned' you wouldn't have that problem..
While you're at it please also cook up an ide-cd variant, having partitions
only supported on scsi cdroms is more than confusing.
next prev parent reply other threads:[~2004-02-24 17:06 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-02-23 2:11 [PATCH] 2.6.2, Partition support for SCSI CDROM Steven J. Hill
2004-02-23 3:00 ` Andrew Morton
2004-02-23 3:07 ` Steven J. Hill
2004-02-23 3:13 ` Andrew Morton
2004-02-24 6:11 ` Jeremy Higdon
2004-02-24 16:51 ` Steven J. Hill
2004-02-24 17:06 ` Christoph Hellwig [this message]
2004-02-26 22:51 ` Rusty Russell
2004-02-24 17:09 ` Matthew Wilcox
2004-02-25 1:58 ` Miles Bader
2004-02-25 10:19 ` Andries Brouwer
2004-02-27 3:22 ` Bill Davidsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040224170626.A25066@infradead.org \
--to=hch@infradead.org \
--cc=akpm@osdl.org \
--cc=jeremy@sgi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=sjhill@realitydiluted.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox