From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg KH Subject: Re: [BK PATCH] SCSI update for 2.6.3 Date: Tue, 24 Feb 2004 13:41:07 -0800 Sender: linux-scsi-owner@vger.kernel.org Message-ID: <20040224214107.GB2045@kroah.com> References: <20040224170412.GA31268@kroah.com> <1077642529.1804.170.camel@mulgrave> <20040224171629.GA31369@kroah.com> <20040224101512.A19617@beaverton.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mail.kroah.org ([65.200.24.183]:42662 "EHLO perch.kroah.org") by vger.kernel.org with ESMTP id S262485AbUBXVm5 (ORCPT ); Tue, 24 Feb 2004 16:42:57 -0500 Content-Disposition: inline In-Reply-To: <20040224101512.A19617@beaverton.ibm.com> List-Id: linux-scsi@vger.kernel.org To: Patrick Mansfield Cc: James Bottomley , Kai Makisara , Linus Torvalds , Andrew Morton , SCSI Mailing List , Linux Kernel , kai.makisara@kolumbus.fi On Tue, Feb 24, 2004 at 10:15:12AM -0800, Patrick Mansfield wrote: > On Tue, Feb 24, 2004 at 09:16:29AM -0800, Greg KH wrote: > > > > > Can you print out the sysfs tree this patch creates? > > > > What's that "tape" symlink for? Does it go from the scsi device in > > /sys/devices/... to the class device? Or the other way around? > > > > Other than that question, the patch looks sane to me. > > Current 2.6 kernel default names are of the form: st[0-9]m[0-3][n] > > Current /dev naming is of the form: [n]st[0-9][alm] > > Should the st kernel names be changed to map to current /dev names? Yes, to make it easier for everyone, they should. Any reason why the kernel names are currently different from what we have in Documentation/devices.txt? I really feel we should follow the standard here :) thanks, greg k-h