From: Christoph Hellwig <hch@infradead.org>
To: Dave Boutcher <sleddog@us.ibm.com>
Cc: linux-scsi@vger.kernel.org
Subject: Re: [PATCH] ibmvscsi driver - third version
Date: Wed, 25 Feb 2004 13:45:18 +0000 [thread overview]
Message-ID: <20040225134518.A4238@infradead.org> (raw)
In-Reply-To: <opr3u0ffo7l6e53g@us.ibm.com>; from sleddog@us.ibm.com on Mon, Feb 23, 2004 at 11:34:17PM -0600
On Mon, Feb 23, 2004 at 11:34:17PM -0600, Dave Boutcher wrote:
> This is the third version of the SCSI driver to support the adapter
> implemented by the IBM Power5 firmware. I have incorporated all comments
> from the previous submissions. Probably the most significant functional
> change is that all locking is done with the host_lock now.
This one still has the issue with error returns from queuecommand.
Here are the rules for queuecommand again:
- either your return 0, then you must finish the command through it's
->done callback
- or you return SCSI_MLQUEUE_HOST_BUSY/SCSI_MLQUEUE_DEVICE_BUSY and must
_not_ call ->done.
There's also a fair share of style issues left. What about simply running
it through scripts/Lindent?
next prev parent reply other threads:[~2004-02-25 13:45 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-02-24 5:34 [PATCH] ibmvscsi driver - third version Dave Boutcher
2004-02-25 13:45 ` Christoph Hellwig [this message]
2004-02-25 17:53 ` [PATCH] ibmvscsi driver - fourth version Dave Boutcher
2004-03-11 17:43 ` James Bottomley
2004-03-11 21:25 ` Dave Boutcher
2004-03-11 22:07 ` James Bottomley
2004-03-12 15:59 ` [PATCH] ibmvscsi driver - fifth version Dave Boutcher
2004-03-31 21:26 ` [PATCH] ibmvscsi driver - sixth version Dave Boutcher
2004-03-31 21:58 ` James Bottomley
2004-03-31 22:37 ` Dave Boutcher
2004-03-31 22:02 ` Jeff Garzik
2004-03-31 23:12 ` Dave Boutcher
2004-03-31 23:39 ` James Bottomley
2004-03-31 23:51 ` Dave Boutcher
2004-04-01 0:10 ` Jeff Garzik
2004-04-01 6:17 ` [PATCH] qla2xxx: sleep while IRQ disabled fix in eh_abort Andrew Vasquez
2004-04-01 15:04 ` James Bottomley
2004-04-01 0:16 ` [PATCH] ibmvscsi driver - sixth version Jeff Garzik
2004-04-01 6:03 ` Andrew Vasquez
2004-04-01 7:13 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040225134518.A4238@infradead.org \
--to=hch@infradead.org \
--cc=linux-scsi@vger.kernel.org \
--cc=sleddog@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox