public inbox for linux-scsi@vger.kernel.org
 help / color / mirror / Atom feed
From: Jeremy Higdon <jeremy@sgi.com>
To: James Bottomley <James.Bottomley@SteelEye.com>
Cc: mpm@waste.org, SCSI Mailing List <linux-scsi@vger.kernel.org>
Subject: Re: [RFC] Make the SCSI mempool allocations variable
Date: Wed, 10 Mar 2004 02:07:40 -0800	[thread overview]
Message-ID: <20040310100740.GA619810@sgi.com> (raw)
In-Reply-To: <1078858977.1756.40.camel@mulgrave>

On Tue, Mar 09, 2004 at 02:02:55PM -0500, James Bottomley wrote:
> Based on Jeremy's request to increase max_phys_segments, this is the way
> to do it (SCSI_MAX_PHYS_SEGMENTS) is the value that gets set as the
> queue's max_phys_segments.
> 
> I have to say that when I tried raising it to 256 and hammering a 10GB
> ext2 filesystem, I still didn't generate any >128 segment requests, so
> I'm dubious that raising it has any benefit at all, but feel free to try
> it and publish the figures.
> 
> I did wonder if lowering it might help improve the memory footprint for
> some embedded systems, so I set it up to be lowered as far as 32.
> 
> James


I got a chance to try this tonight and can report excellent results.
I modified the qla2xxx driver to have an sg_tablesize of 256 (default
is SG_ALL, which is 0xFF).  I also modified SCSI_MAX_PHYS_SEGMENTS to
256.

I first tried direct I/O to the block device and found that the max
I/O size increased to 4MB from 2MB.  I then built an XFS filesystem and
tried direct I/O to it, and found the same results.

Believe it or not, there are some h/w RAIDs in which you can get a
significant performance benefit by increasing I/O size to 4MB from
2MB.  I don't have one immediately available to post MB/s numbers,
but you can trust me ('cause I can trust those who told me) :-)

So I heartily approve of this change.

Are you thinking of making SCSI_MAX_PHYS_SEGMENTS a config variable?
Or would you increase it to 256 by default?

Thanks for doing this,

jeremy

  parent reply	other threads:[~2004-03-10 10:08 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-03-09 19:02 [RFC] Make the SCSI mempool allocations variable James Bottomley
2004-03-10  6:21 ` Jeremy Higdon
2004-03-10 10:07 ` Jeremy Higdon [this message]
2004-03-10 15:29   ` James Bottomley
2004-03-11  6:38     ` Jeremy Higdon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040310100740.GA619810@sgi.com \
    --to=jeremy@sgi.com \
    --cc=James.Bottomley@SteelEye.com \
    --cc=linux-scsi@vger.kernel.org \
    --cc=mpm@waste.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox