Re: 2.6.3 CONFIG_SCSI_AIC7 X X X Kconfig bug

Matthew Wilcox
2004-03-11T13:32:24Z

On Thu, Mar 11, 2004 at 02:18:11PM +0100, Olaf Hering wrote:
> On Thu, Mar 11, Matthew Wilcox wrote:
> > On Thu, Mar 11, 2004 at 01:53:33PM +0100, Olaf Hering wrote:
> > > On Thu, Mar 11, Matthew Wilcox wrote:
> > > > config SCSI_SATA
> > > > bool "Serial ATA (SATA) support"
> > > > - depends on SCSI && EXPERIMENTAL
> > > > + depends on EXPERIMENTAL
> > > > config SCSI_SATA_SVW
> > > > tristate "ServerWorks Frodo / Apple K2 SATA support (EXPERIMENTAL)"
> > > > - depends on SCSI_SATA && PCI && EXPERIMENTAL
> > > > + depends on SCSI_SATA && PCI && (X86 || PPC) && EXPERIMENTAL
> > >
> > > how do you handle the SCSI=m here? sata remains =y. I havent tried to
> > > load scsi_mod and sd_mod, is SCSI=m supposed to work for SATA?
> >
> > Putting the 'depends on SCSI' attribute on the menu means it applies to
> > every item in the menu. So if SCSI=m, SCSI_SATA would also be constrained
> > to 'm' or 'n'.
>
> even with 'bool' instead ot 'tristate'?

Oh, good point. Actually, I think this patch fixes a bug in the current
Kconfiggery. Right now (and I just confirmed this):

SCSI=m
SCSI_SATA=y
SCSI_SATA_SVW can be Y/N/M

With my patch, SCSI_SATA_SVW inherits a dependency on SCSI as well as
SCSI_SATA and is thus constrained to be M/N (which would be correct).

--
"Next the statesmen will invent cheap lies, putting the blame upon
the nation that is attacked, and every man will be glad of those
conscience-soothing falsities, and will diligently study them, and refuse
to examine any refutations of them; and thus he will by and by convince
himself that the war is just, and will thank God for the better sleep
he enjoys after this process of grotesque self-deception." -- Mark Twain