From: Anton Blanchard <anton@samba.org>
To: James Bottomley <James.Bottomley@steeleye.com>
Cc: Jens Axboe <axboe@suse.de>,
Andrew Vasquez <andrew.vasquez@qlogic.com>,
SCSI Mailing List <linux-scsi@vger.kernel.org>
Subject: Re: PATCH [5/15] qla2xxx: SG tablesize update
Date: Mon, 15 Mar 2004 02:47:13 +1100 [thread overview]
Message-ID: <20040314154713.GH19737@krispykreme> (raw)
In-Reply-To: <1079278279.2022.34.camel@mulgrave>
> If you think you don't know how many resource slots you'll need, that's
> in scsi_cmnd->request->nr_hw_segments (give or take, this is always
> guaranteed to be at or over the actual number dma_map_sg eventually
> returns). So: fix the qlogic mapping routines.
Yes I agree the driver should be fixed. My question was more a response
to the Jens' query about why the SG limit was introduced.
Lets ignore the pci_map_sg problem and assume the qlogic driver did the
right thing. Whats to stop the upper layers from continually trying to
queue things when we run out of request slots? If its just sg_tablesize
then we are stuck with the current compromise (ie set it to something
reasonably low).
Anton
next prev parent reply other threads:[~2004-03-14 15:52 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-03-14 8:24 PATCH [5/15] qla2xxx: SG tablesize update Andrew Vasquez
2004-03-14 14:49 ` James Bottomley
2004-03-14 14:51 ` Jens Axboe
2004-03-14 14:59 ` James Bottomley
2004-03-14 15:15 ` Jens Axboe
2004-03-14 15:18 ` Anton Blanchard
2004-03-14 15:31 ` James Bottomley
2004-03-14 15:47 ` Anton Blanchard [this message]
2004-03-14 15:55 ` James Bottomley
2004-03-14 16:01 ` Anton Blanchard
2004-03-14 20:41 ` Jeff Garzik
2004-03-14 22:27 ` James Bottomley
2004-03-15 16:12 ` Jeff Garzik
2004-03-14 20:36 ` Jeff Garzik
2004-03-14 22:31 ` James Bottomley
2004-03-15 16:09 ` Jeff Garzik
-- strict thread matches above, loose matches on Subject: below --
2004-03-15 23:43 Andrew Vasquez
2004-03-16 3:37 ` James Bottomley
2004-03-16 6:40 ` Jeremy Higdon
2004-03-16 11:32 ` Anton Blanchard
2004-03-16 21:49 ` James Bottomley
2004-03-16 22:09 Andrew Vasquez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040314154713.GH19737@krispykreme \
--to=anton@samba.org \
--cc=James.Bottomley@steeleye.com \
--cc=andrew.vasquez@qlogic.com \
--cc=axboe@suse.de \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox