From: Matthew Dharm <mdharm-scsi@one-eyed-alien.net>
To: Alan Stern <stern@rowland.harvard.edu>
Cc: Patrick Mansfield <patmans@us.ibm.com>,
James Bottomley <James.Bottomley@steeleye.com>,
linux-scsi@vger.kernel.org, usb-storage@lists.one-eyed-alien.net
Subject: Re: adding flag for 192 byte mode sense
Date: Tue, 16 Mar 2004 10:02:39 -0800 [thread overview]
Message-ID: <20040316180238.GA19787@one-eyed-alien.net> (raw)
In-Reply-To: <Pine.LNX.4.44L0.0403161214510.815-100000@ida.rowland.org>
[-- Attachment #1: Type: text/plain, Size: 1049 bytes --]
On Tue, Mar 16, 2004 at 12:25:03PM -0500, Alan Stern wrote:
> +
> + /* We can't put these settings in slave_alloc() because that gets
> + * called before the device type is known. Consequently these
> + * settings can't be overridden via the scsi devinfo mechanism. */
> + if (sdev->type == TYPE_DISK) {
> +
> + /* Disk-type devices use MODE SENSE(6) if the protocol
> + * (SubClass) is Transparent SCSI */
> + if (us->subclass == US_SC_SCSI)
> + sdev->use_10_for_ms = 0;
> + } else {
> +
> + /* Non-disk-type devices don't need to blacklist MS page x08
> + * or to force 192 byte transfer lengths for MODE SENSE */
> + sdev->skip_ms_page_8 = 0;
> + sdev->use_192_bytes_for_3f = 0;
> + }
>
Do we know what non-disk type devices use for MODE_SENSE? That would
(primarily) be CD-ROMs, I think...
Matt
--
Matthew Dharm Home: mdharm-usb@one-eyed-alien.net
Maintainer, Linux USB Mass Storage Driver
Somebody call an exorcist!
-- Dust Puppy
User Friendly, 5/16/1998
[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]
next prev parent reply other threads:[~2004-03-16 18:02 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-03-14 1:46 adding flag for 192 byte mode sense Patrick Mansfield
2004-03-14 1:49 ` [PATCH] Replace scsi_host flags with scsi_device sdev_bflags Patrick Mansfield
2004-03-14 1:50 ` [PATCH] Add 192 byte MODE SENSE flag Patrick Mansfield
2004-03-16 17:25 ` adding flag for 192 byte mode sense Alan Stern
2004-03-16 18:02 ` Matthew Dharm [this message]
2004-03-16 20:08 ` Alan Stern
2004-03-16 20:27 ` [usb-storage] " Pat LaVarre
2004-03-22 16:16 ` Alan Stern
2004-03-22 16:31 ` James Bottomley
2004-03-22 17:28 ` Alan Stern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040316180238.GA19787@one-eyed-alien.net \
--to=mdharm-scsi@one-eyed-alien.net \
--cc=James.Bottomley@steeleye.com \
--cc=linux-scsi@vger.kernel.org \
--cc=patmans@us.ibm.com \
--cc=stern@rowland.harvard.edu \
--cc=usb-storage@lists.one-eyed-alien.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox