From: Martin Hicks <mort@wildopensource.com>
To: James Bottomley <James.Bottomley@steeleye.com>
Cc: linux-scsi@vger.kernel.org
Subject: [PATCH] Fix template size calculation in transport attributes
Date: Mon, 29 Mar 2004 12:22:01 -0500 [thread overview]
Message-ID: <20040329172201.GB18948@localhost> (raw)
[-- Attachment #1: Type: text/plain, Size: 198 bytes --]
Hi,
This small patch fixes the template size calculation in
{spi,fc}_attach_transport().
Thanks
mh
--
Martin Hicks Wild Open Source Inc.
mort@wildopensource.com 613-266-2296
[-- Attachment #2: transport-attrs-template-size.patch --]
[-- Type: text/plain, Size: 1674 bytes --]
# This is a BitKeeper generated patch for the following project:
# Project Name: Linux kernel tree
# This patch format is intended for GNU patch command version 2.5 or higher.
# This patch includes the following deltas:
# ChangeSet 1.1663 -> 1.1664
# drivers/scsi/scsi_transport_fc.c 1.2 -> 1.3
# drivers/scsi/scsi_transport_spi.c 1.5 -> 1.6
#
# The following is the BitKeeper ChangeSet Log
# --------------------------------------------
# 04/03/29 mort@tomahawk.engr.sgi.com 1.1664
# Fix a bug in the SPI and FC transport attributes code.
# The calculation of template size was wrong.
# --------------------------------------------
#
diff -Nru a/drivers/scsi/scsi_transport_fc.c b/drivers/scsi/scsi_transport_fc.c
--- a/drivers/scsi/scsi_transport_fc.c Mon Mar 29 09:19:12 2004
+++ b/drivers/scsi/scsi_transport_fc.c Mon Mar 29 09:19:12 2004
@@ -159,7 +159,7 @@
i->t.attrs = &i->attrs[0];
i->t.class = &fc_transport_class;
i->t.setup = &fc_setup_transport_attrs;
- i->t.size = sizeof(struct fc_transport_attrs) - sizeof(unsigned long);
+ i->t.size = sizeof(struct fc_transport_attrs);
i->f = ft;
SETUP_ATTRIBUTE_RD(port_id);
diff -Nru a/drivers/scsi/scsi_transport_spi.c b/drivers/scsi/scsi_transport_spi.c
--- a/drivers/scsi/scsi_transport_spi.c Mon Mar 29 09:19:12 2004
+++ b/drivers/scsi/scsi_transport_spi.c Mon Mar 29 09:19:12 2004
@@ -632,7 +632,7 @@
i->t.attrs = &i->attrs[0];
i->t.class = &spi_transport_class;
i->t.setup = &spi_setup_transport_attrs;
- i->t.size = sizeof(struct spi_transport_attrs) - sizeof(unsigned long);
+ i->t.size = sizeof(struct spi_transport_attrs);
i->f = ft;
SETUP_ATTRIBUTE(period);
reply other threads:[~2004-03-29 17:22 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040329172201.GB18948@localhost \
--to=mort@wildopensource.com \
--cc=James.Bottomley@steeleye.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox