Re: [PATCH] SATA Transport Attributes

Jeff Garzik
2004-03-30T01:23:56Z

Martin Hicks wrote:
> Hello,
>
> Here is a patch that introduces a Transport Attribute class for SATA
> devices. The patch also includes an update to the Vitesse driver to use
> the transport attribute.
>
> The only problem that I'm having right now is that sometimes I get
> a NULL pointer dereference in scsi_remove_device() when I rmmod sata_vsc.
> Although sdev->host->transportt->cleanup is NULL coming into the
> function, the call to class_device_unregister(&sdev->transport_classdev)
> somtimes makes ->cleanup non-NULL and bad things happen from there.
>
> I could not reproduce this when calling rmmod on the qla2200 driver.
>
> Any comments on this patch? Any ideas about this rmmod issue?
>
> The patch is against 2.6.5-rc1.

hmmm... since libata is moving out of drivers/scsi in 2.7, I would
rather leave it as-is. The port number is easily found from userspace,
assuming you know the PCI device, with zero code. This adds ~300 lines
of code to do that which is already doable... :)

Jeff