public inbox for linux-scsi@vger.kernel.org
 help / color / mirror / Atom feed
* scsi-misc BK tree: Fix scsi_device_get to allow NULL devices
@ 2004-04-05 11:55 Christoph Hellwig
  2004-04-05 14:05 ` Mike Anderson
  0 siblings, 1 reply; 3+ messages in thread
From: Christoph Hellwig @ 2004-04-05 11:55 UTC (permalink / raw)
  To: linux-scsi

Can the SuSE guys please elaborate what this patch is supposed to solve?
We should never pass a NULL pointer to scsi_device_get..

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: scsi-misc BK tree: Fix scsi_device_get to allow NULL devices
  2004-04-05 11:55 scsi-misc BK tree: Fix scsi_device_get to allow NULL devices Christoph Hellwig
@ 2004-04-05 14:05 ` Mike Anderson
  2004-04-19  9:38   ` Christoph Hellwig
  0 siblings, 1 reply; 3+ messages in thread
From: Mike Anderson @ 2004-04-05 14:05 UTC (permalink / raw)
  To: Christoph Hellwig; +Cc: linux-scsi

Christoph Hellwig [hch@infradead.org] wrote:
> Can the SuSE guys please elaborate what this patch is supposed to solve?
> We should never pass a NULL pointer to scsi_device_get..

I agree. If this is happening then something is wrong in the scsi
support of the device model.

-andmike
--
Michael Anderson
andmike@us.ibm.com


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: scsi-misc BK tree: Fix scsi_device_get to allow NULL devices
  2004-04-05 14:05 ` Mike Anderson
@ 2004-04-19  9:38   ` Christoph Hellwig
  0 siblings, 0 replies; 3+ messages in thread
From: Christoph Hellwig @ 2004-04-19  9:38 UTC (permalink / raw)
  To: james.bottomley; +Cc: linux-scsi

On Mon, Apr 05, 2004 at 07:05:52AM -0700, Mike Anderson wrote:
> Christoph Hellwig [hch@infradead.org] wrote:
> > Can the SuSE guys please elaborate what this patch is supposed to solve?
> > We should never pass a NULL pointer to scsi_device_get..
> 
> I agree. If this is happening then something is wrong in the scsi
> support of the device model.

As no one stands up to defend the patch could we please remove it again?
I saw it made it into 2.6.6-rc1 despite the critisism.


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2004-04-19  9:38 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-04-05 11:55 scsi-misc BK tree: Fix scsi_device_get to allow NULL devices Christoph Hellwig
2004-04-05 14:05 ` Mike Anderson
2004-04-19  9:38   ` Christoph Hellwig

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox