Re: Fix for memory leak problem in megaraid2.c /proc entries (fwd)

[Matthew Wilcox <willy@debian.org>]

On Thu, Apr 08, 2004 at 11:29:20AM -0400, Lester Hightower wrote:
> This diff fixes a memory leak in megaraid2.c, v2.10.1 (Dec 03, 2003):
> 
> [root@10east scsi]# diff megaraid2.c.MEMORY_LEAK.20040408.lhh megaraid2.c
> 3395c3395,3399
> <       if( channel >= max_channels ) return 0;
> ---
> >       if( channel >= max_channels ) {
> >               pci_free_consistent(pdev, 256, scsi_inq, scsi_inq_dma_handle);
> >               mega_free_inquiry(inquiry, dma_handle, pdev);
> >               return 0;
> >         }

FYI, in future please use diff -u to generate diffs; they are much more
robust and easier to read than the diff default.

-- 
"Next the statesmen will invent cheap lies, putting the blame upon 
the nation that is attacked, and every man will be glad of those
conscience-soothing falsities, and will diligently study them, and refuse
to examine any refutations of them; and thus he will by and by convince 
himself that the war is just, and will thank God for the better sleep 
he enjoys after this process of grotesque self-deception." -- Mark Twain