public inbox for linux-scsi@vger.kernel.org
 help / color / mirror / Atom feed
From: Anton Blanchard <anton@samba.org>
To: James.Smart@emulex.com
Cc: linux-scsi@vger.kernel.org
Subject: emulex FC driver on ppc64
Date: Sat, 10 Apr 2004 12:21:24 +1000	[thread overview]
Message-ID: <20040410022124.GI18493@krispykreme> (raw)


Hi James,

I gave the sourceforge version of the emulex FC driver a spin on my
ppc64 box. Good news is it worked out of the box. I had a few
observations:

1. request_irq uses SA_INTERRUPT and SA_SHIRQ. I cant see mixing these
flags could be safe, and I doubt you need the SA_INTERRUPT in the first
place. Removing it also makes it easier to use timer tick profiling
because the interrupt routing runs with irqs on.

2. We now have dma_mapping_error so you can kill the NO_TCE, -1 hacks.

3. A number of the files need to be un dosified, they have carriage
returns in them.

4. lpfc_bad_scatterlist is pretty nasty stuff. If its going to be
impossible to get your firmware guys to fix this issue we could look at
working around it in the ppc64 IOMMU code. At least then we wont have to
walk each SG list, however theres every chance another architecture is
going to have the same problem.

5. #define MAX_ELX_BRDS 32
Do we need a hard limit? Can we just dynamically allocate the
structures? 32 is going to be way too small for some of our setups.
btw your MODULE_PARM code is scary :)

Anton

             reply	other threads:[~2004-04-10  2:25 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-04-10  2:21 Anton Blanchard [this message]
  -- strict thread matches above, loose matches on Subject: below --
2004-04-11  0:18 emulex FC driver on ppc64 Smart, James
2004-04-11  0:44 ` Jeff Garzik
2004-04-11 11:59 Smart, James
2004-04-13 18:21 ` Jeff Garzik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040410022124.GI18493@krispykreme \
    --to=anton@samba.org \
    --cc=James.Smart@emulex.com \
    --cc=linux-scsi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox