Re: CDC_RAM for lk 2.4, PATCH proposed

Jens Axboe
2004-05-20T08:06:31Z

On Wed, May 19 2004, Pat LaVarre wrote:
> Jens A:
>
> > Please explain your reasoning for this patch.
>
> I fear to answer fully, because I see I have a history of answering in
> ways that make you lose interest.

Sorry you feel that way. It's not loss of interesting, mainly juggling
other tasks.

> I see you have not yet volunteered to review the 2.4.26 patch proposed
> in this thread 2004-04-23 by John McKell, written to give us CDC_RAM
> alone without MRW in 2.4.
>
> Can I help best by updating that patch to become a 2.4.27-pre3 patch?

2.4.26 patch should apply to 2.4.27-pre3 as well, I think. But it
doesn't hurt to check.

> ----- ----- -----
>
> P.S. An alternative, less short reply that I also drafted was:
>
> > > linux-2.4.18/drivers/ide/ide-cd.c
> > if we succeed in getting the mode sense capabilities page,
> > you force setting og dvd-rom/ram?!
> > ...
> > > linux-2.4.18/drivers/scsi/sr.c
> > Ditto here.
>
> Yes.
>
> I believe 2.4.18 patch actually makes `mount -w` work there by way of
> "see all DVD/CD drives as DVD-RAM/ DVD-ROM compatible".

But that's not what the patch does at all. The patch simply says "If we
succeeded in retriving the mode capability page, ignore what it says and
flag the drive as dvd-rom/ram capable" which is clearly bogus.

--
Jens Axboe