From: Christoph Hellwig <hch@infradead.org>
To: "Bagalkote, Sreenivas" <sreenib@lsil.com>
Cc: "'jgarzik@pobox.com'" <jgarzik@pobox.com>,
"'Matt_Domsch@dell.com'" <Matt_Domsch@dell.com>,
"'paul@kungfoocoder.org'" <paul@kungfoocoder.org>,
"'James.Bottomley@SteelEye.com'" <James.Bottomley@SteelEye.com>,
"'arjanv@redhat.com'" <arjanv@redhat.com>,
"'linux-scsi@vger.kernel.org'" <linux-scsi@vger.kernel.org>,
"'linux-kernel@vger.kernel.org'" <linux-kernel@vger.kernel.org>
Subject: Re: [ANNOUNCE][RELEASE]: megaraid unified driver version 2.20.0.B1
Date: Fri, 16 Apr 2004 13:18:40 +0100 [thread overview]
Message-ID: <20040416131840.E5080@infradead.org> (raw)
In-Reply-To: <0E3FA95632D6D047BA649F95DAB60E570230C7B4@exa-atlanta.se.lsil.com>; from sreenib@lsil.com on Wed, Apr 07, 2004 at 07:18:02PM -0400
kdep.h:
- mraid_scsi_host_alloc/mraid_scsi_host_dealloc should go away, just
define scsi_host_alloc/scsi_host_put wrappers for 2.4.
- mraid_scsi_set_pdev should go away, it's not needed in 2.6 at all
because scsi_add_host does all the work and for 2.4 just use
scsi_set_pci_device directly.
- all the SCP2FOO defines should go away, the 2.6 variants work for 2.4
aswell
- mraid_set_host_lock should go, just use scsi_assign_lock and define
it for 2.4.
megaraid_clib.c:
- why do you need the scb pool managment code at all? You can dynamically
allocate scbs in ->queuecommand
- can you explain the need for all the mraid_pci_blk_pool? I.e. why the
generic dma pool routines don't work for megaraid
all files:
- please avoid using scsi.h and hosts.h from drivers/scsi in favour of
the include/scsi/ headers, especially get rid of all the Scsi_Foo
typedefs
prev parent reply other threads:[~2004-04-16 12:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-04-07 23:18 [ANNOUNCE][RELEASE]: megaraid unified driver version 2.20.0.B1 Bagalkote, Sreenivas
2004-04-08 23:56 ` Paul Wagland
2004-04-16 12:18 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040416131840.E5080@infradead.org \
--to=hch@infradead.org \
--cc=James.Bottomley@SteelEye.com \
--cc=Matt_Domsch@dell.com \
--cc=arjanv@redhat.com \
--cc=jgarzik@pobox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=paul@kungfoocoder.org \
--cc=sreenib@lsil.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox