public inbox for linux-scsi@vger.kernel.org
 help / color / mirror / Atom feed
From: Kurt Garloff <garloff@suse.de>
To: Christoph Hellwig <hch@infradead.org>
Cc: Linux SCSI list <linux-scsi@vger.kernel.org>
Subject: Re: [PATCH] 1/6: scsi_largelun and scsi_sparselun
Date: Mon, 19 Apr 2004 00:10:38 +0200	[thread overview]
Message-ID: <20040418221038.GL4868@tpkurt.garloff.de> (raw)
In-Reply-To: <20040418201852.A3393@infradead.org>

[-- Attachment #1: Type: text/plain, Size: 1107 bytes --]

On Sun, Apr 18, 2004 at 08:18:52PM +0100, Christoph Hellwig wrote:
> On Sun, Apr 18, 2004 at 08:58:20PM +0200, Kurt Garloff wrote:
> > +static int scsi_sparselun;
> > +module_param_named(scsi_sparselun, scsi_sparselun, int, S_IRUGO|S_IWUSR);
                        ^^^^^
> > +MODULE_PARM_DESC(scsi_sparselun,
                      ^^^^^
> > +		 "Assume sparse LUNs for all SCSI devices");
> > +
> > +static int scsi_largelun;
> > +module_param_named(scsi_largelun, scsi_largelun, int, S_IRUGO|S_IWUSR);
                        ^^^^^
> > +MODULE_PARM_DESC(scsi_largelun,
                      ^^^^^
> > +		 "Assume all SCSI-2 devs support more than 8 LUNs");
> 
> The names are badly chosen.  On the bootline commandline they already
> have a scsi_mod. prefix, so the additional scsi_ is superflous.

Good point, so I'll remove all scsi_ prefixes.

Regards,
-- 
Kurt Garloff                   <kurt@garloff.de>             [Koeln, DE]
Physics:Plasma modeling <garloff@plasimo.phys.tue.nl> [TU Eindhoven, NL]
Linux: SUSE Labs (Head)        <garloff@suse.de>    [SUSE Nuernberg, DE]

[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]

      reply	other threads:[~2004-04-18 22:10 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-04-18 18:58 [PATCH] 1/6: scsi_largelun and scsi_sparselun Kurt Garloff
2004-04-18 19:18 ` Christoph Hellwig
2004-04-18 22:10   ` Kurt Garloff [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040418221038.GL4868@tpkurt.garloff.de \
    --to=garloff@suse.de \
    --cc=hch@infradead.org \
    --cc=linux-scsi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox