From: Patrick Mansfield <patmans@us.ibm.com>
To: Kurt Garloff <garloff@suse.de>,
Christoph Hellwig <hch@infradead.org>,
Linux SCSI list <linux-scsi@vger.kernel.org>
Subject: Re: [PATCH] 5/6: scsi_inq_timeout
Date: Mon, 19 Apr 2004 09:41:06 -0700 [thread overview]
Message-ID: <20040419094106.A31555@beaverton.ibm.com> (raw)
In-Reply-To: <20040418221610.GN4868@tpkurt.garloff.de>; from garloff@suse.de on Mon, Apr 19, 2004 at 12:16:10AM +0200
On Mon, Apr 19, 2004 at 12:16:10AM +0200, Kurt Garloff wrote:
> On Sun, Apr 18, 2004 at 08:21:09PM +0100, Christoph Hellwig wrote:
> > On Sun, Apr 18, 2004 at 08:59:57PM +0200, Kurt Garloff wrote:
> > > +#ifdef __powerpc64__
> > > +static unsigned int scsi_inq_timeout = SCSI_TIMEOUT/HZ+25;
> > > +#else
> > > +static unsigned int scsi_inq_timeout = SCSI_TIMEOUT/HZ+3;
> > > +#endif
> >
> > Huh? per-arch ifdefs in the scsi code are completely bogus.
>
> Well, those broken chips seem to be very common on machines from
> a specific vendor that ships PPC64 hardware ...
> That hunk could be dropped of course in mainline, I would not mind.
Why not increase it for all cases? And/or make it a config value?
It won't slow down functioning hardware, just the cases where we get no
response.
-- Patrick Mansfield
next prev parent reply other threads:[~2004-04-19 16:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-04-18 18:59 [PATCH] 5/6: scsi_inq_timeout Kurt Garloff
2004-04-18 19:21 ` Christoph Hellwig
2004-04-18 22:16 ` Kurt Garloff
2004-04-19 16:41 ` Patrick Mansfield [this message]
2004-04-20 11:34 ` Kurt Garloff
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040419094106.A31555@beaverton.ibm.com \
--to=patmans@us.ibm.com \
--cc=garloff@suse.de \
--cc=hch@infradead.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox