public inbox for linux-scsi@vger.kernel.org
 help / color / mirror / Atom feed
From: Kurt Garloff <garloff@suse.de>
To: Patrick Mansfield <patmans@us.ibm.com>
Cc: Christoph Hellwig <hch@infradead.org>,
	Linux SCSI list <linux-scsi@vger.kernel.org>
Subject: Re: [PATCH] 5/6: scsi_inq_timeout
Date: Tue, 20 Apr 2004 13:34:14 +0200	[thread overview]
Message-ID: <20040420113414.GF4356@tpkurt.garloff.de> (raw)
In-Reply-To: <20040419094106.A31555@beaverton.ibm.com>

[-- Attachment #1: Type: text/plain, Size: 739 bytes --]

On Mon, Apr 19, 2004 at 09:41:06AM -0700, Patrick Mansfield wrote:
> Why not increase it for all cases? And/or make it a config value? 

Config value is stpuid. I made it a boot parameter.

> It won't slow down functioning hardware, just the cases where we get no
> response.

True, you should get selection timeouts there.
(Or the equivalent on non SPI transports.)

Still, 5s is already quite long; I would dislike the kernel needing
25s to recognize a broken device, just because somebody had built
screwed up hardware.

I'll drop the arch specific default.

Regards,
-- 
Kurt Garloff  <garloff@suse.de>                            Cologne, DE 
SUSE LINUX AG, Nuernberg, DE                          SUSE Labs (Head)

[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]

      reply	other threads:[~2004-04-20 11:34 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-04-18 18:59 [PATCH] 5/6: scsi_inq_timeout Kurt Garloff
2004-04-18 19:21 ` Christoph Hellwig
2004-04-18 22:16   ` Kurt Garloff
2004-04-19 16:41     ` Patrick Mansfield
2004-04-20 11:34       ` Kurt Garloff [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040420113414.GF4356@tpkurt.garloff.de \
    --to=garloff@suse.de \
    --cc=hch@infradead.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=patmans@us.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox