Re: [PATCH] i2o_block Fix, possible CFQ elevator problem?

Jens Axboe
2004-04-20T10:56:29Z

On Tue, Apr 20 2004, Warren Togami wrote:
> Jens Axboe wrote:
> >>>Not necessarily, it's most likely a CFQ bug. Otherwise it would have
> >>>surfaced before :-)
> >>>
> >>
> >>I forgot to mention in the previous reports:
> >>
> >>Prior to three of your original suggested cleanups of i2o_block, four
> >>simultaneous bonnie++'s on four independent arrays would almost
> >>immediately cause the crash while running elevator=cfq. After those
> >>three cleanups four simultaneous bonnie++ would survive for a while
> >>without crashing... until you run "sync" in another terminal. We
> >>however did not test it enough times to determine if without "sync" it
> >>can survive the test run. Do you want this tested without "sync"?
> >
> >
> >Repeat the tests that made it crash. The last patch I sent should work
> >for you, at least until the real issue is found.
> >
>
> Tested your patch, it indeed does seem to keep the system stable. If I
> am understanding it right, the patch disables merging in the case where
> it would have caused a BUG condition? (Less efficiency.)

Not quite, it just removes the crq from the hash before it can do any
damage. It doesn't impact efficiency, the request is removed from the io
scheduler at this point anyway.

> In any case, for now we are doing our i2o development using the other
> schedulers like deadline. Let us know if you have updated cfq patches
> to try, and we will.

I'll see if I can reproduce it here.

--
Jens Axboe