Re: PATCH 4/5: scsi-scan-dont-att-pq-notcon

[Kurt Garloff <garloff@suse.de>]

[-- Attachment #1.1: Type: text/plain, Size: 667 bytes --]

On Wed, Apr 21, 2004 at 04:02:58PM +0100, Christoph Hellwig wrote:
> On Wed, Apr 21, 2004 at 04:14:17PM +0200, Kurt Garloff wrote:
> > 
> > Don't attach high level drivers (except sg) to devices with peripheral
> > qualifier indicating not connected (1) or not capable (3).
> > SPC3, 7.4.2.
> 
> Please don't duplicate it in every driver but in scsi_bus_match.  sg uses
> a completely different attachment path so it shouldn't be affected by that.

Is it safe to assume it will stay like this?

Regards,
-- 
Kurt Garloff  <garloff@suse.de>                            Cologne, DE 
SUSE LINUX AG, Nuernberg, DE                          SUSE Labs (Head)

[-- Attachment #1.2: scsi-scan-nomatch-pq-notcon --]
[-- Type: text/plain, Size: 659 bytes --]

diff -uNrp linux-2.6.5.attach/drivers/scsi/scsi_sysfs.c linux-2.6.5.noattach/drivers/scsi/scsi_sysfs.c
--- linux-2.6.5.attach/drivers/scsi/scsi_sysfs.c	2004-04-04 05:36:26.000000000 +0200
+++ linux-2.6.5.noattach/drivers/scsi/scsi_sysfs.c	2004-04-21 17:22:22.000000000 +0200
@@ -155,7 +155,9 @@ struct class sdev_class = {
 /* all probing is done in the individual ->probe routines */
 static int scsi_bus_match(struct device *dev, struct device_driver *gendrv)
 {
-	return 1;
+	struct scsi_device *sdp = to_scsi_device(dev);
+	int pq = (sdp->inquiry[0] >> 5) & 7;
+	return (pq == SCSI_INQ_PQ_CON)? 1: 0;
 }
 
 struct bus_type scsi_bus_type = {

[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]