Re: PATCH 4/5: scsi-scan-dont-att-pq-notcon

[Patrick Mansfield <patmans@us.ibm.com>]

On Thu, Apr 22, 2004 at 12:51:37AM +0200, Kurt Garloff wrote:
> On Wed, Apr 21, 2004 at 09:55:01AM -0700, Patrick Mansfield wrote:
> > On Wed, Apr 21, 2004 at 11:18:30AM -0500, James Bottomley wrote:
> > > There's logic to parsing data where it's needed, but it makes it
> > > difficult to locate all the places when it changes...
> > 
> > So add a macro or inline function to parse the data, like a sdev_pq(sdev),
> > then we have one location for the parsing, and don't have to duplicate the
> > data. And if sdev->inquiry changes or goes away we need only change
> > sdev_pq().
> 
> #define sdev_pg(sdev) ((sdev->inquiry[0] >> 5) & 7)
> 
> Just there is no scsi_scan.h where we could stick this.
> So either we have it at some non-obvious place or just once in
> scsi_sysfs.c. Or in scsi_scan.c and add one char to struct scsi_dev.
> I believe it's a very minor issue.

Yes, it's minor; James hasn't replied, and there aren't any other macros
like I'm suggesting, so go with the extra char.

-- Patrick Mansfield