* [PATCH] sata_vsc initialization fix
@ 2004-04-23 2:15 Jeremy Higdon
2004-04-23 18:08 ` Jeremy Higdon
0 siblings, 1 reply; 3+ messages in thread
From: Jeremy Higdon @ 2004-04-23 2:15 UTC (permalink / raw)
To: jgarzik, linux-scsi
I neglected to initialize a couple of registers that are usually
zero, but not always. :-)
Please apply.
jeremy
# This is a BitKeeper generated patch for the following project:
# Project Name: Linux kernel tree
# This patch format is intended for GNU patch command version 2.5 or higher.
# This patch includes the following deltas:
# ChangeSet 1.1783 -> 1.1784
# drivers/scsi/sata_vsc.c 1.6 -> 1.7
#
# The following is the BitKeeper ChangeSet Log
# --------------------------------------------
# 04/04/22 jeremy@tomahawk.engr.sgi.com 1.1784
# Fix sata_vsc to initialize upper address pointer registers.
# --------------------------------------------
#
diff -Nru a/drivers/scsi/sata_vsc.c b/drivers/scsi/sata_vsc.c
--- a/drivers/scsi/sata_vsc.c Thu Apr 22 19:14:14 2004
+++ b/drivers/scsi/sata_vsc.c Thu Apr 22 19:14:14 2004
@@ -44,6 +44,8 @@
#define VSC_SATA_TF_CTL_OFFSET 0x29
/* DMA base */
+#define VSC_SATA_UP_DESCIPTOR_OFFSET 0x64
+#define VSC_SATA_UP_DATA_BUFFER_OFFSET 0x6C
#define VSC_SATA_DMA_CMD_OFFSET 0x70
/* SCRs base */
@@ -234,6 +236,8 @@
port->ctl_addr = base + VSC_SATA_TF_CTL_OFFSET;
port->bmdma_addr = base + VSC_SATA_DMA_CMD_OFFSET;
port->scr_addr = base + VSC_SATA_SCR_STATUS_OFFSET;
+ writel(0, base + VSC_SATA_UP_DESCIPTOR_OFFSET);
+ writel(0, base + VSC_SATA_UP_DATA_BUFFER_OFFSET);
}
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] sata_vsc initialization fix
2004-04-23 2:15 [PATCH] sata_vsc initialization fix Jeremy Higdon
@ 2004-04-23 18:08 ` Jeremy Higdon
2004-04-25 2:16 ` Jeff Garzik
0 siblings, 1 reply; 3+ messages in thread
From: Jeremy Higdon @ 2004-04-23 18:08 UTC (permalink / raw)
To: jgarzik, linux-scsi; +Cc: erikj, jbarnes
A typo was spotted (DESCIPTOR ==> DESCRIPTOR).
diff -Nru a/drivers/scsi/sata_vsc.c b/drivers/scsi/sata_vsc.c
--- a/drivers/scsi/sata_vsc.c Thu Apr 22 19:14:14 2004
+++ b/drivers/scsi/sata_vsc.c Thu Apr 22 19:14:14 2004
@@ -44,6 +44,8 @@
#define VSC_SATA_TF_CTL_OFFSET 0x29
/* DMA base */
+#define VSC_SATA_UP_DESCRIPTOR_OFFSET 0x64
+#define VSC_SATA_UP_DATA_BUFFER_OFFSET 0x6C
#define VSC_SATA_DMA_CMD_OFFSET 0x70
/* SCRs base */
@@ -234,6 +236,8 @@
port->ctl_addr = base + VSC_SATA_TF_CTL_OFFSET;
port->bmdma_addr = base + VSC_SATA_DMA_CMD_OFFSET;
port->scr_addr = base + VSC_SATA_SCR_STATUS_OFFSET;
+ writel(0, base + VSC_SATA_UP_DESCRIPTOR_OFFSET);
+ writel(0, base + VSC_SATA_UP_DATA_BUFFER_OFFSET);
}
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2004-04-25 2:16 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-04-23 2:15 [PATCH] sata_vsc initialization fix Jeremy Higdon
2004-04-23 18:08 ` Jeremy Higdon
2004-04-25 2:16 ` Jeff Garzik
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox