From: Olaf Hering <olh@suse.de>
To: linux-scsi@vger.kernel.org, akpm@osdl.org
Subject: [PATCH] signed bug in scsi_device.h
Date: Thu, 13 May 2004 18:43:06 +0200 [thread overview]
Message-ID: <20040513164306.GA27050@suse.de> (raw)
one of the recent aic7xxx versions puts a -1 in scsi_cmnd->device->type,
in drivers/scsi/aic7xxx/aic79xx_osm.c
that doesnt work very well on ppc because aic7xxx tends to use -Werror.
maybe scsi_level needs the signed as well.
--- ./include/scsi/scsi_device.h~ 2004-05-13 18:22:20.000000000 +0200
+++ ./include/scsi/scsi_device.h 2004-05-13 18:27:37.000000000 +0200
@@ -57,7 +57,7 @@ struct scsi_device {
void *hostdata; /* available to low-level driver */
char devfs_name[256]; /* devfs junk */
- char type;
+ signed char type;
char scsi_level;
unsigned char inquiry_len; /* valid bytes in 'inquiry' */
unsigned char * inquiry; /* INQUIRY response data */
--
USB is for mice, FireWire is for men!
sUse lINUX ag, nÜRNBERG
-
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next reply other threads:[~2004-05-13 16:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-05-13 16:43 Olaf Hering [this message]
2004-05-13 17:10 ` [PATCH] signed bug in scsi_device.h Christoph Hellwig
2004-05-13 17:16 ` Olaf Hering
2004-05-13 17:17 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040513164306.GA27050@suse.de \
--to=olh@suse.de \
--cc=akpm@osdl.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox