From: Olaf Hering <olh@suse.de>
To: Christoph Hellwig <hch@infradead.org>
Cc: linux-scsi@vger.kernel.org, akpm@osdl.org
Subject: Re: [PATCH] signed bug in scsi_device.h
Date: Thu, 13 May 2004 19:16:29 +0200 [thread overview]
Message-ID: <20040513171629.GA31832@suse.de> (raw)
In-Reply-To: <20040513181047.A13153@infradead.org>
On Thu, May 13, Christoph Hellwig wrote:
> On Thu, May 13, 2004 at 06:43:06PM +0200, Olaf Hering wrote:
> >
> > one of the recent aic7xxx versions puts a -1 in scsi_cmnd->device->type,
> > in drivers/scsi/aic7xxx/aic79xx_osm.c
> > that doesnt work very well on ppc because aic7xxx tends to use -Werror.
> >
> > maybe scsi_level needs the signed as well.
>
> Maybe aic7xxx should stop doing stuff like that instead?
probably. Can you fix up scsi_alloc_sdev in the meantime?
I just looked again, the check was device->type != -1.
Maybe our enterprise compiler is just too pedantic. I really dont know.
--
USB is for mice, FireWire is for men!
sUse lINUX ag, nÜRNBERG
-
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2004-05-13 17:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-05-13 16:43 [PATCH] signed bug in scsi_device.h Olaf Hering
2004-05-13 17:10 ` Christoph Hellwig
2004-05-13 17:16 ` Olaf Hering [this message]
2004-05-13 17:17 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040513171629.GA31832@suse.de \
--to=olh@suse.de \
--cc=akpm@osdl.org \
--cc=hch@infradead.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox