From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [PATCH] signed bug in scsi_device.h Date: Thu, 13 May 2004 18:17:48 +0100 Sender: linux-scsi-owner@vger.kernel.org Message-ID: <20040513181748.A13315@infradead.org> References: <20040513164306.GA27050@suse.de> <20040513181047.A13153@infradead.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from phoenix.infradead.org ([213.86.99.234]:43270 "EHLO phoenix.infradead.org") by vger.kernel.org with ESMTP id S264098AbUEMRRt (ORCPT ); Thu, 13 May 2004 13:17:49 -0400 Content-Disposition: inline In-Reply-To: <20040513181047.A13153@infradead.org>; from hch@infradead.org on Thu, May 13, 2004 at 06:10:47PM +0100 List-Id: linux-scsi@vger.kernel.org To: Olaf Hering Cc: linux-scsi@vger.kernel.org, akpm@osdl.org On Thu, May 13, 2004 at 06:10:47PM +0100, Christoph Hellwig wrote: > On Thu, May 13, 2004 at 06:43:06PM +0200, Olaf Hering wrote: > > > > one of the recent aic7xxx versions puts a -1 in scsi_cmnd->device->type, > > in drivers/scsi/aic7xxx/aic79xx_osm.c > > that doesnt work very well on ppc because aic7xxx tends to use -Werror. > > > > maybe scsi_level needs the signed as well. > > Maybe aic7xxx should stop doing stuff like that instead? Okay, I take that back, it should be signed indeed. That doesn't mean aic7xxx should ever write to that field, though.