From: Christoph Hellwig <hch@infradead.org>
To: "Smart, James" <James.Smart@Emulex.com>
Cc: "'linux-scsi@vger.kernel.org'" <linux-scsi@vger.kernel.org>
Subject: Re: [(re)Announce] Emulex LightPulse Device Driver
Date: Tue, 18 May 2004 12:59:50 +0100 [thread overview]
Message-ID: <20040518125950.A9363@infradead.org> (raw)
In-Reply-To: <3356669BBE90C448AD4645C843E2BF28034F92F0@xbl.ma.emulex.com>; from James.Smart@Emulex.com on Sun, May 09, 2004 at 12:33:35AM -0400
the driver lacks dma-mapping includes all over the place which makes it
fail at least on ppc32. while we're at it reorder includes alphabetically.
diff -urp lpfcdriver-2.6-8.0.1/lpfc_ct.c lpfcdriver-2.6-8.0.1.hch/lpfc_ct.c
--- lpfcdriver-2.6-8.0.1/lpfc_ct.c 2004-05-16 20:03:37.000000000 +0200
+++ lpfcdriver-2.6-8.0.1.hch/lpfc_ct.c 2004-05-18 13:17:42.595315904 +0200
@@ -28,6 +28,7 @@
#include <linux/version.h>
#include <linux/spinlock.h>
#include <linux/utsname.h>
+#include <linux/dma-mapping.h>
#include <linux/pci.h>
#include <linux/utsname.h>
diff -urp lpfcdriver-2.6-8.0.1/lpfc_els.c lpfcdriver-2.6-8.0.1.hch/lpfc_els.c
--- lpfcdriver-2.6-8.0.1/lpfc_els.c 2004-05-16 20:03:37.000000000 +0200
+++ lpfcdriver-2.6-8.0.1.hch/lpfc_els.c 2004-05-18 13:18:09.426236984 +0200
@@ -21,12 +21,11 @@
/*
* $Id: lpfc_els.c,v 1.10 2004/05/16 14:24:55 jselx Exp $
*/
-#include <linux/version.h>
-#include <linux/spinlock.h>
-#include <linux/pci.h>
-
-
#include <linux/blkdev.h>
+#include <linux/dma-mapping.h>
+#include <linux/pci.h>
+#include <linux/spinlock.h>
+#include <linux/version.h>
#include <scsi/scsi_device.h>
#include "lpfc_hw.h"
diff -urp lpfcdriver-2.6-8.0.1/lpfc_hbadisc.c lpfcdriver-2.6-8.0.1.hch/lpfc_hbadisc.c
--- lpfcdriver-2.6-8.0.1/lpfc_hbadisc.c 2004-05-16 20:03:37.000000000 +0200
+++ lpfcdriver-2.6-8.0.1.hch/lpfc_hbadisc.c 2004-05-18 13:18:39.805618616 +0200
@@ -22,12 +22,12 @@
* $Id: lpfc_hbadisc.c,v 1.10 2004/05/16 14:24:55 jselx Exp $
*/
-#include <linux/version.h>
-#include <linux/spinlock.h>
+#include <linux/blkdev.h>
+#include <linux/dma-mapping.h>
#include <linux/pci.h>
+#include <linux/spinlock.h>
+#include <linux/version.h>
-
-#include <linux/blkdev.h>
#include <scsi/scsi.h>
#include <scsi/scsi_device.h>
diff -urp lpfcdriver-2.6-8.0.1/lpfc_init.c lpfcdriver-2.6-8.0.1.hch/lpfc_init.c
--- lpfcdriver-2.6-8.0.1/lpfc_init.c 2004-05-16 20:03:37.000000000 +0200
+++ lpfcdriver-2.6-8.0.1.hch/lpfc_init.c 2004-05-18 13:19:08.068322032 +0200
@@ -22,14 +22,14 @@
* $Id: lpfc_init.c,v 1.10 2004/05/16 14:30:20 jselx Exp $
*/
-#include <linux/version.h>
-#include <linux/spinlock.h>
+#include <linux/blkdev.h>
+#include <linux/ctype.h>
+#include <linux/dma-mapping.h>
#include <linux/pci.h>
+#include <linux/spinlock.h>
+#include <linux/version.h>
-
-#include <linux/blkdev.h>
#include <scsi/scsi_device.h>
-#include <linux/ctype.h>
#include "lpfc_version.h"
#include "lpfc_hw.h"
diff -urp lpfcdriver-2.6-8.0.1/lpfc_mbox.c lpfcdriver-2.6-8.0.1.hch/lpfc_mbox.c
--- lpfcdriver-2.6-8.0.1/lpfc_mbox.c 2004-05-16 20:03:37.000000000 +0200
+++ lpfcdriver-2.6-8.0.1.hch/lpfc_mbox.c 2004-05-18 13:19:35.834100992 +0200
@@ -21,12 +21,12 @@
/*
* $Id: lpfc_mbox.c,v 1.8 2004/04/29 23:24:00 jselx Exp $
*/
-#include <linux/version.h>
-#include <linux/spinlock.h>
+#include <linux/blkdev.h>
+#include <linux/dma-mapping.h>
#include <linux/pci.h>
+#include <linux/spinlock.h>
+#include <linux/version.h>
-
-#include <linux/blkdev.h>
#include <scsi/scsi_device.h>
#include "lpfc_hw.h"
diff -urp lpfcdriver-2.6-8.0.1/lpfc_nportdisc.c lpfcdriver-2.6-8.0.1.hch/lpfc_nportdisc.c
--- lpfcdriver-2.6-8.0.1/lpfc_nportdisc.c 2004-05-16 20:03:37.000000000 +0200
+++ lpfcdriver-2.6-8.0.1.hch/lpfc_nportdisc.c 2004-05-18 13:20:00.839299624 +0200
@@ -22,12 +22,12 @@
* $Id: lpfc_nportdisc.c,v 1.10 2004/05/16 14:31:05 jselx Exp $
*/
-#include <linux/version.h>
-#include <linux/spinlock.h>
+#include <linux/blkdev.h>
+#include <linux/dma-mapping.h>
#include <linux/pci.h>
+#include <linux/spinlock.h>
+#include <linux/version.h>
-
-#include <linux/blkdev.h>
#include <scsi/scsi_device.h>
#include "lpfc_hw.h"
diff -urp lpfcdriver-2.6-8.0.1/lpfc_sli.c lpfcdriver-2.6-8.0.1.hch/lpfc_sli.c
--- lpfcdriver-2.6-8.0.1/lpfc_sli.c 2004-05-16 20:03:38.000000000 +0200
+++ lpfcdriver-2.6-8.0.1.hch/lpfc_sli.c 2004-05-18 12:58:15.823692152 +0200
@@ -27,6 +27,7 @@
#include <linux/blkdev.h>
+#include <linux/dma-mapping.h>
#include <linux/pci.h>
#include <scsi/scsi_device.h>
next prev parent reply other threads:[~2004-05-18 11:59 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-05-09 4:33 [(re)Announce] Emulex LightPulse Device Driver Smart, James
2004-05-09 8:20 ` Christoph Hellwig
2004-05-09 8:51 ` Christoph Hellwig
2004-05-10 16:34 ` Matthew Wilcox
2004-05-18 11:59 ` Christoph Hellwig [this message]
2004-05-18 12:08 ` Christoph Hellwig
-- strict thread matches above, loose matches on Subject: below --
2004-05-10 16:47 Smart, James
2004-05-13 21:21 David.Egolf
2004-05-13 21:26 ` Christoph Hellwig
2004-05-14 19:51 Smart, James
2004-05-14 20:03 ` 'Christoph Hellwig'
2004-05-17 21:25 Smart, James
2004-05-18 9:58 ` 'Christoph Hellwig'
2004-05-18 13:00 Smart, James
2004-05-18 13:04 Smart, James
2004-05-18 13:07 ` 'Christoph Hellwig'
2004-05-18 13:08 Smart, James
2004-05-18 13:09 Smart, James
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040518125950.A9363@infradead.org \
--to=hch@infradead.org \
--cc=James.Smart@Emulex.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox