Re: [PATCH] tmscsim: new interfaces

[Christoph Hellwig <hch@infradead.org>]

On Sat, May 22, 2004 at 09:34:47PM +0200, Guennadi Liakhovetski wrote:
> Ok, here comes the risky (and, so far, the last) one. It updates the
> driver to use the "new" pci, scsi, and module interfaces. It is risky,
> because it changes quite a bit, and I, unfortunatly, can only test it in
> one configuration - compiled in (not as a module), and I don't have any
> devices, that support tagged command queues, and it is just an onboard
> AM53C974 chip without EEPROM.

Looks mostly goo to me, one thing I worry about is the complete
removal of the scan_device flag, I don't fully understand what it's
supposed to do, but we should be able to always set in ->slave_alloc
and then clear it in ->slave_configure when we know probing is over
for this device.

The other thing is that most calls to dc390_findDCB could probably be
replaced with stroing the pDCB in scsi_device->hostdata on slave_alloc,
but that could aswell be done in an incremental patch.

In dc390_init_one you don't call pci_disable_device on failure,
best switch to goto for a single shared error path to avoid all
these leaks.  Maybe also  merge dc390_init and dc390_init_one?

Similarly I think DC390_release should be merged into dc390_remove_one.