From: Christoph Hellwig <hch@lst.de>
To: Adam Radford <aradford@amcc.com>
Cc: linux-scsi@vger.kernel.org
Subject: Re: [PATCH/RFC 2/2] 3ware 9000 SATA-RAID driver
Date: Sun, 23 May 2004 13:02:48 +0200 [thread overview]
Message-ID: <20040523110248.GB10790@lst.de> (raw)
In-Reply-To: <HY4ODS03.B9L@hadar.amcc.com>
> +#include <linux/version.h>
what do you need this one for?
> +#define TW_VENDOR_ID (0x13C1) /* 3ware */
> +#define TW_DEVICE_ID_9000 (0x1002) /* 9000 series controller */
Should be in include/linux/pci_ids.h
> +/* Function prototypes */
> +static int twa_aen_complete(TW_Device_Extension *tw_dev, int request_id);
> +static int twa_aen_drain_queue(TW_Device_Extension *tw_dev, int check_reset);
> +static void twa_aen_queue_event(TW_Device_Extension *tw_dev, TW_Command_Apache_Header *header);
please don't put prototypes into a header if they're used only in a
single file. try to reorder the .c file that additiona prototype
declarations aren't needed as much as possible and put everything else
in the .c file.
prev parent reply other threads:[~2004-05-23 11:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-05-22 18:22 [PATCH/RFC 2/2] 3ware 9000 SATA-RAID driver Adam Radford
2004-05-23 11:02 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040523110248.GB10790@lst.de \
--to=hch@lst.de \
--cc=aradford@amcc.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox