Re: [PATCH] tmscsim: new interfaces

[Christoph Hellwig <hch@infradead.org>]

On Thu, May 27, 2004 at 11:20:50PM +0200, Guennadi Liakhovetski wrote:
> On Wed, 26 May 2004, Christoph Hellwig wrote:
> 
> > Looks like a way to go.  I'm not sure what scan_device is supposed to
> > do as I already wrote, but from looking at when it's set/cleared I'm
> > pretty sure it tries to indicate whethere we're currently scanning for
> > devices.  And useing slave_alloc/slave_configure is a much safer way to
> > find that out then guessing from the commands sent.
> 
> Attached is a patch, that moves scan_device to
> slave_alloc/_configure/_destroy, as you suggested (to be precise, as I
> understood your suggestion:-)). Please consider. The patch also contains
> some more clean-up. Don't know, if you, James, would prefer it as a
> separate patch, or left alone altogether. Those minor details are
> disturbing the eye, but are, perhaps, not important enough to bother you
> with a separate patch:-) But if you want it separate - no problem, will do
> that.
> 
> As usual, tested on my AM53C974.

Looks good to me.