From: Christoph Hellwig <hch@lst.de>
To: "Salyzyn, Mark" <mark_salyzyn@adaptec.com>
Cc: Andrew Morton <akpm@osdl.org>,
linux-scsi@vger.kernel.org, Leon Toh <tltoh@attglobal.net>,
Christoph Hellwig <hch@lst.de>
Subject: Re: 2.6.6 + Adaptec I2O
Date: Tue, 1 Jun 2004 17:20:20 +0200 [thread overview]
Message-ID: <20040601152020.GA6706@lst.de> (raw)
In-Reply-To: <547AF3BD0F3F0B4CBDC379BAC7E4189FAD510E@otce2k03.adaptec.com>
On Tue, Jun 01, 2004 at 11:11:22AM -0400, Salyzyn, Mark wrote:
> Please read CHANGELOG.dpt_i2o for change documentation.
>
> Two changes recently posted by Christoph Hellwig have been incorporated
> in this patch.
>
> This patch has aimed towards 2.6 purity, and although the sources
> maintained at Adaptec are unified (2.4 & 2.6), scripts were used to
> remove the ifdef KERNEL_VERSION from this release. This source is in
> synchronized with the patch on May 19th submitted for dpt_i2o in the 2.4
> tree.
>
> I look forward to comments regarding this patch.
Patch is mostly okay although it still won't win a beaty contest.
Two showstoppers though:
- the spin_is_locked magic is really, really bogus. Easiest way to
avoid this is to have your own spinlock in adpt_hba and use
scsi_assign_lock to make it the host_lock, too. With a little
magic you'll also get per-host locks in the various 2.4 vendor
trees with that..
- you're still trying to sneak DPT_TARGET_BUSY back in.
Please fix those two issues and the patch can go in.
next prev parent reply other threads:[~2004-06-01 15:20 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-06-01 15:11 2.6.6 + Adaptec I2O Salyzyn, Mark
2004-06-01 15:20 ` Christoph Hellwig [this message]
2004-06-01 15:23 ` Christoph Hellwig
2004-06-02 8:11 ` Leon Toh
2004-06-02 8:16 ` Christoph Hellwig
2004-06-01 17:08 ` Andi Kleen
-- strict thread matches above, loose matches on Subject: below --
2004-06-01 15:38 Salyzyn, Mark
2004-06-01 15:54 ` Christoph Hellwig
2004-06-01 16:09 Salyzyn, Mark
2004-06-01 17:25 Salyzyn, Mark
2004-06-01 18:20 ` Andi Kleen
2004-06-01 18:27 Salyzyn, Mark
2004-06-01 18:29 ` Matthew Wilcox
2004-06-01 18:39 Salyzyn, Mark
2004-06-01 19:25 ` Andi Kleen
2004-06-01 19:52 Salyzyn, Mark
2004-06-01 20:29 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040601152020.GA6706@lst.de \
--to=hch@lst.de \
--cc=akpm@osdl.org \
--cc=linux-scsi@vger.kernel.org \
--cc=mark_salyzyn@adaptec.com \
--cc=tltoh@attglobal.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox