From: Christoph Hellwig <hch@lst.de>
To: "Salyzyn, Mark" <mark_salyzyn@adaptec.com>
Cc: Christoph Hellwig <hch@lst.de>, Andrew Morton <akpm@osdl.org>,
linux-scsi@vger.kernel.org, Leon Toh <tltoh@attglobal.net>
Subject: Re: 2.6.6 + Adaptec I2O
Date: Tue, 1 Jun 2004 17:54:14 +0200 [thread overview]
Message-ID: <20040601155414.GA7476@lst.de> (raw)
In-Reply-To: <547AF3BD0F3F0B4CBDC379BAC7E4189FAD5115@otce2k03.adaptec.com>
On Tue, Jun 01, 2004 at 11:38:16AM -0400, Salyzyn, Mark wrote:
> *this* DPT_TARGET_BUSY did the bd_claim you indicated would be
> appropriate ... the bus_for_each_dev() call could be dropped though, it
> was simply wishful thinking that we could expand on that idea to get the
> busy check functionality back.
bd_claim/bd_release is paired for a reason. So you must call bd_claim
before you start your exclusive operation and bd_release afterwards,
your combination just doesn't make sense.
In addition you're calling bd_claim on the inode of the managment
_character_ device. I honestly can't see how you ever tested this as
it should immediately crash.
next prev parent reply other threads:[~2004-06-01 15:54 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-06-01 15:38 2.6.6 + Adaptec I2O Salyzyn, Mark
2004-06-01 15:54 ` Christoph Hellwig [this message]
-- strict thread matches above, loose matches on Subject: below --
2004-06-01 19:52 Salyzyn, Mark
2004-06-01 20:29 ` Andi Kleen
2004-06-01 18:39 Salyzyn, Mark
2004-06-01 19:25 ` Andi Kleen
2004-06-01 18:27 Salyzyn, Mark
2004-06-01 18:29 ` Matthew Wilcox
2004-06-01 17:25 Salyzyn, Mark
2004-06-01 18:20 ` Andi Kleen
2004-06-01 16:09 Salyzyn, Mark
2004-06-01 15:11 Salyzyn, Mark
2004-06-01 15:20 ` Christoph Hellwig
2004-06-01 15:23 ` Christoph Hellwig
2004-06-02 8:11 ` Leon Toh
2004-06-02 8:16 ` Christoph Hellwig
2004-06-01 17:08 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040601155414.GA7476@lst.de \
--to=hch@lst.de \
--cc=akpm@osdl.org \
--cc=linux-scsi@vger.kernel.org \
--cc=mark_salyzyn@adaptec.com \
--cc=tltoh@attglobal.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox