public inbox for linux-scsi@vger.kernel.org
 help / color / mirror / Atom feed
From: Jeremy Higdon <jeremy@sgi.com>
To: linux-scsi@vger.kernel.org
Cc: emoore@lsil.com
Subject: [PATCH 2.6]  Add readX_relaxed to MPT Fusion driver
Date: Wed, 2 Jun 2004 23:24:39 -0700	[thread overview]
Message-ID: <20040603062439.GA59204@sgi.com> (raw)

This patch makes use of readX_relaxed to improve PIO read
response times on platforms that define them (currently
SGI Altix :-), but it could be used in conjunction with the
PCI-X relaxed ordering attribute on another platform in the
future).

>From what I could see, there was only one PIO read in which
it was unsafe for the response to pass DMA write data, so
I made the default readX_relaxed.

jeremy


diff -ur -X /usr/people/jeremy/dontdiff linux-2.6.6/drivers/message/fusion/mptbase.c linux-2.6.7-rc1/drivers/message/fusion/mptbase.c
--- linux-2.6.6/drivers/message/fusion/mptbase.c	2004-05-28 23:14:11.000000000 -0700
+++ linux-2.6.7-rc1/drivers/message/fusion/mptbase.c	2004-05-27 16:48:09.000000000 -0700
@@ -282,7 +282,8 @@
 };
 MODULE_DEVICE_TABLE(pci, mptbase_pci_table);
 
-#define CHIPREG_READ32(addr) 		readl(addr)
+#define CHIPREG_READ32(addr) 		readl_relaxed(addr)
+#define CHIPREG_READ32_dmasync(addr)	readl(addr)
 #define CHIPREG_WRITE32(addr,val) 	writel(val, addr)
 #define CHIPREG_PIO_WRITE32(addr,val)	outl(val, (unsigned long)addr)
 #define CHIPREG_PIO_READ32(addr) 	inl((unsigned long)addr)
@@ -347,7 +348,7 @@
 	 */
 	while (1) {
 
-		if ((pa = CHIPREG_READ32(&ioc->chip->ReplyFifo)) == 0xFFFFFFFF)
+		if ((pa = CHIPREG_READ32_dmasync(&ioc->chip->ReplyFifo)) == 0xFFFFFFFF)
 			return IRQ_HANDLED;
 
 		cb_idx = 0;

                 reply	other threads:[~2004-06-03  6:25 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040603062439.GA59204@sgi.com \
    --to=jeremy@sgi.com \
    --cc=emoore@lsil.com \
    --cc=linux-scsi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox