From: Christoph Hellwig <hch@infradead.org>
To: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Cc: Christoph Hellwig <hch@infradead.org>,
James Bottomley <James.Bottomley@steeleye.com>,
Kurt Garloff <garloff@suse.de>,
Linux SCSI list <linux-scsi@vger.kernel.org>
Subject: Re: [PATCH] tmscsim: init / exit cleanup
Date: Thu, 3 Jun 2004 14:38:35 +0100 [thread overview]
Message-ID: <20040603133835.GA16378@infradead.org> (raw)
In-Reply-To: <Pine.LNX.4.44.0405312248150.3168-200000@poirot.grange>
On Mon, May 31, 2004 at 11:13:51PM +0200, Guennadi Liakhovetski wrote:
> On Sun, 23 May 2004, Christoph Hellwig wrote:
>
> > these leaks. Maybe also merge dc390_init and dc390_init_one?
> >
> > Similarly I think DC390_release should be merged into dc390_remove_one.
>
> Attached. Also fixed some __init / __devinit and __exit / __devexit
> attributes. Although, would be good to have something like
>
> #ifdef CONFIG_HOTPLUG_PCI
> #define __pcidevinit
> #define __pcidevinitdata
> #define __pcidevexit
> #define __pcidevexitdata
> #else
> #define __pcidevinit __init
> #define __pcidevinitdata __initdata
> #define __pcidevexit __exit
> #define __pcidevexitdata __exitdata
> #endif
>
> I don't think there are any pcmcia / usb / ieee1394 / ... tmscsim adapters
> out there?
This has been though out a bit but not considered worthwile. And to actually
work it would have to be for all the kernel because you could get problems
over the module boundary otherwise.
next prev parent reply other threads:[~2004-06-03 13:38 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20040518184527.GC4859@tpkurt.garloff.de>
2004-05-18 19:47 ` [BK PATCH] SCSI updates for 2.6.6 Guennadi Liakhovetski
2004-05-18 20:38 ` James Bottomley
2004-05-19 19:50 ` [PATCH] tmscsim: 64-bit cleanup Guennadi Liakhovetski
2004-05-19 21:34 ` [PATCH] tmscsim: no internal queue Guennadi Liakhovetski
2004-05-21 15:15 ` [PATCH] tmscsim: 64-bit cleanup James Bottomley
2004-05-21 22:53 ` Guennadi Liakhovetski
2004-05-22 8:09 ` Kurt Garloff
2004-05-22 15:43 ` James Bottomley
2004-05-22 18:10 ` Kurt Garloff
2004-05-22 19:34 ` [PATCH] tmscsim: new interfaces Guennadi Liakhovetski
2004-05-23 10:37 ` Christoph Hellwig
2004-05-23 21:19 ` Guennadi Liakhovetski
2004-05-26 11:45 ` Christoph Hellwig
2004-05-26 19:37 ` [PATCH] fix comment in scsi_host.h Guennadi Liakhovetski
2004-05-26 21:07 ` [PATCH] tmscsim: new interfaces Guennadi Liakhovetski
2004-05-27 21:20 ` Guennadi Liakhovetski
2004-05-28 13:00 ` Christoph Hellwig
2004-05-29 15:36 ` James Bottomley
2004-05-30 21:01 ` [PATCH] tmscsim: Store pDCB in device->hostdata Guennadi Liakhovetski
2004-05-31 9:22 ` Christoph Hellwig
2004-05-31 21:13 ` [PATCH] tmscsim: init / exit cleanup Guennadi Liakhovetski
2004-06-03 13:38 ` Christoph Hellwig [this message]
2004-06-03 20:23 ` Guennadi Liakhovetski
2004-06-06 17:09 ` Christoph Hellwig
2004-06-08 6:37 ` Kurt Garloff
2004-05-22 19:38 ` [PATCH] tmscsim: 64-bit cleanup Guennadi Liakhovetski
2004-06-04 22:17 ` Guennadi Liakhovetski
2004-06-05 8:12 ` Guennadi Liakhovetski
2004-06-05 14:02 ` James Bottomley
2004-06-05 20:37 ` Guennadi Liakhovetski
2004-06-05 21:06 ` James Bottomley
2004-06-06 15:06 ` Guennadi Liakhovetski
2004-06-14 21:37 ` Guennadi Liakhovetski
2004-05-21 1:06 ` [BK PATCH] SCSI updates for 2.6.6 Chiaki
2004-05-18 22:17 ` Matthew Wilcox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040603133835.GA16378@infradead.org \
--to=hch@infradead.org \
--cc=James.Bottomley@steeleye.com \
--cc=g.liakhovetski@gmx.de \
--cc=garloff@suse.de \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox