Re: Patch for iriver-mp3player

[Matthew Dharm <mdharm-scsi@one-eyed-alien.net>]

[-- Attachment #1: Type: text/plain, Size: 1642 bytes --]

On Sun, Jun 06, 2004 at 09:48:51AM -0500, James Bottomley wrote:
> On Sat, 2004-05-29 at 18:42, Tobias Lieber wrote:
> > i Javier Marcet wrote in January 2004 a patch for linux-2.6.3, to make a i-River-mp3-Player mounting. It was on lkml: http://lkml.org/lkml/2004/1/6/170
> > i was suprised, that it was not in the kernel, and no other soulution, too. So i read his patch for getting mouted the player, and rewrote it for linux-2.6.7-rc1-bk7. I attached it. It would be nice, if it would be possible mounting the mp3-player without patching the Kernel, so i would greet it, if this or an other solution woulg com into the Kernel.
> 
> Well, but the question is who gets to fix this?
> 
> Since this is a USB device returning broken inquiry data which sd then
> acts on, I'd rather see USB fix it.
> 
> I cc'd the USB people.  Since you already do some scrubbing on the
> inquiry data from this thing (to fix up the ANSI SCSI type), can't you
> just add it as an unusual dev that needs the RMB bit resetting (and, if
> that's so far wrong, probably other vital pieces of inquiry data as
> well)?

We're actually trying to figure out the 'right way' to do this now.  Our
expectation is that there is some algorithmic way to determine if this bit
is "right" or not, as Windows seems to get it right without
white/blacklisting.

Matt

-- 
Matthew Dharm                              Home: mdharm-usb@one-eyed-alien.net 
Maintainer, Linux USB Mass Storage Driver

We've made a business out of making money from annoying and stupid people.
I think you fall under that category.
					-- Chief
User Friendly, 7/11/1998

[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]