From: Mike Anderson <andmike@us.ibm.com>
To: linux-scsi@vger.kernel.org
Cc: hch@infradead.org, jgarzik@pobox.com
Subject: Clarification - export of scsi_finish_command and scsi_times_out
Date: Tue, 8 Jun 2004 16:18:05 -0700 [thread overview]
Message-ID: <20040608231805.GE1360@us.ibm.com> (raw)
On a previous thread to resolve a libata issue scsi_finish_command was
exported. The thread can be reference at the url below.
http://marc.theaimsgroup.com/?t=107799572900002&r=1&w=2
My question is why did we export scsi_finish_command and not a wrapper
that included scsi_decide_disposition. If a LLDD did not have a
eh_strategy routine it is possible post recovery the io would be
retried. Is it because it was believed that these timed out commands
handled by the libata eh_strategy_handler would most likely not succeed
on retry?
Also there was a previous patch posted by Christoph to allow a LLDD to
handle timeouts directly instead of waiting for the host_failed count to
be reached where they could then be handled in a eh_strategy_handler.
http://marc.theaimsgroup.com/?l=linux-scsi&m=107460498631200&w=2
What is the current thought on this patch.
-andmike
--
Michael Anderson
andmike@us.ibm.com
next reply other threads:[~2004-06-08 23:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-06-08 23:18 Mike Anderson [this message]
2004-06-09 14:11 ` Clarification - export of scsi_finish_command and scsi_times_out James Bottomley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040608231805.GE1360@us.ibm.com \
--to=andmike@us.ibm.com \
--cc=hch@infradead.org \
--cc=jgarzik@pobox.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox